Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Dropping a URL onto URL bar regressed creating a new tab #8750

Closed
bbondy opened this issue May 8, 2017 · 4 comments
Closed

Dropping a URL onto URL bar regressed creating a new tab #8750

bbondy opened this issue May 8, 2017 · 4 comments

Comments

@bbondy
Copy link
Member

bbondy commented May 8, 2017

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    If you drop a file onto the URL bar it should load a new tab with the URL.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    latest

  • Steps to reproduce:

    1. Drop a file onto the urlbar
  • Actual result:
    Uncaught TypeError: windowActions.newFrame

  • Expected result:
    Creates a new tab with the url

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

Introduced here, probably a rebase problem:
1cdaaf3#commitcomment-22049535

@bbondy bbondy added this to the 0.15.3 milestone May 8, 2017
@bbondy bbondy self-assigned this May 8, 2017
@bbondy bbondy changed the title Dropping a url onto URL bar regressed loading the url Dropping a URL onto URL bar regressed creating a new tab May 8, 2017
@bbondy bbondy closed this as completed in b9ac832 May 8, 2017
@srirambv
Copy link
Collaborator

Dropping a file on URL bar doesn't load the file on Windows with 0.15.301
8750

Little confused with the title and the STR. Guessing it is about dropping a file on URL bar

@NejcZdovc
Copy link
Contributor

@srirambv can you please try again. I can't reproduce this on a latest master (macOS).

@luixxiul
Copy link
Contributor

maybe then it's a windows specific issue.

@luixxiul luixxiul added the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label May 12, 2017
@bbondy bbondy closed this as completed in a20be00 May 15, 2017
@bbondy
Copy link
Member Author

bbondy commented May 15, 2017

There was a second independent but from the first fix which was only present on Windows. Where we'd encode file drops' backslashes causes the file URL path to be invalid.

bbondy added a commit that referenced this issue May 15, 2017
@luixxiul luixxiul removed the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Oct 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.