Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

URL parsing is slow #8707

Closed
ayumi opened this issue May 4, 2017 · 0 comments · Fixed by #8708
Closed

URL parsing is slow #8707

ayumi opened this issue May 4, 2017 · 0 comments · Fixed by #8708
Labels
perf QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.15.300 (Frozen,...

Comments

@ayumi
Copy link
Contributor

ayumi commented May 4, 2017 •
edited by luixxiul
Loading

Test plan

#8708 (comment)

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    While investigating URL bar slowness, I noticed suggestion.simpleDomainNameValue() was slow. It calls urlParse() which uses url.parse().
    When I replaced the node core implementation with fast-url-parser it got way faster (10K bookmarks, first keystroke "a" from 2000 ms to 1500 ms).

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version (revision SHA):
    c002e3f
@ayumi ayumi added the perf label May 4, 2017
ayumi added a commit that referenced this issue May 4, 2017
@ayumi
Use fast-url-parser

Verified

This commit was signed with the committer’s verified signature.
cezaraugusto Cezar Augusto
GPG key ID: ECC5FF1C7EA1D39D
Verified
Learn about vigilant mode
3b39964 
Fix #8707

Auditors: @bsclifton @bbondy

Test Plan:
Make sure automated tests pass.
@ayumi ayumi mentioned this issue May 5, 2017
Merged
ayumi added a commit that referenced this issue May 5, 2017
@ayumi
Use fast-url-parser

Verified

This commit was signed with the committer’s verified signature.
cezaraugusto Cezar Augusto
GPG key ID: ECC5FF1C7EA1D39D
Verified
Learn about vigilant mode
7b0f7d5 
Fix #8707

Test Plan:
Make sure automated tests pass.
@luixxiul luixxiul added this to the 0.15.3 milestone May 9, 2017
This was referenced May 23, 2017
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue May 25, 2017
Closed
@bbondy bbondy mentioned this issue May 26, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
perf QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

Successfully merging a pull request may close this issue.

Use fast-url-parser brave/browser-laptop
3 participants
@ayumi @alexwykoff @luixxiul