Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Cleanup share l10n strings to re-use the same string #8604

Closed
bbondy opened this issue May 1, 2017 · 2 comments
Closed

Cleanup share l10n strings to re-use the same string #8604

bbondy opened this issue May 1, 2017 · 2 comments
Assignees
@NejcZdovc
Labels
bug/good-first-bug bug QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@bbondy
Copy link
Member

bbondy commented May 1, 2017 •
edited by luixxiul
Loading

Test plan

#12445 (comment)

See review comment here:
https://github.com/brave/browser-laptop/pull/8517/files/9ce64841f10aa46dcad512307af68966057bca49#diff-985837eca34ef94b3bc9cf3271761dca

It would be cleaner to use the same string for each of these menu items.
@bbondy bbondy mentioned this issue May 1, 2017
Merged
4 tasks
@kumarrishav kumarrishav self-assigned this May 17, 2017
@luixxiul luixxiul added the bug label Jun 5, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@sergio-rojasa
Copy link

I would like to work on this.

This was referenced Dec 29, 2017
Closed
Closed
sergio-rojasa pushed a commit to sergio-rojasa/browser-laptop that referenced this issue Dec 30, 2017
Changed share l10n string to use a generic template for each share me…
189b7d5 
…nu items. Fix brave#8604
@sergio-rojasa sergio-rojasa mentioned this issue Dec 30, 2017
Merged
10 tasks
@NejcZdovc NejcZdovc self-assigned this Dec 31, 2017
@NejcZdovc NejcZdovc modified the milestones: Triage Backlog, 0.22.x (Nightly Channel) Dec 31, 2017
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
This was referenced Jun 11, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Jun 14, 2018 •
edited by LaurenWags
Loading

Verified on Windows x64 using

  • 0.23.8 06c657b
  • muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified on Ubuntu 17.10 x64

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified with macOS 10.12.6 using

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

This was referenced Jun 19, 2018
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jun 27, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug/good-first-bug bug QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
10 participants
@bbondy @kjozwiak @luixxiul @kumarrishav @bsclifton @NejcZdovc @srirambv @sergio-rojasa @LaurenWags @btlechowski