Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Pinning a tab by drag and drop throws an error #8469

Closed
bbondy opened this issue Apr 24, 2017 · 1 comment
Closed

Pinning a tab by drag and drop throws an error #8469

bbondy opened this issue Apr 24, 2017 · 1 comment
Assignees
@bbondy
Labels
QA/no-qa-needed release-notes/exclude
Milestone
0.15.0

Comments

@bbondy
Copy link
Member

bbondy commented Apr 24, 2017

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Dragging a normal tab over top of an already pinned tab is throwing a console error instead of pinning the dropped tab

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    3f589aa

  • Steps to reproduce:

    1. Blank session
    2. Create a pinned tab for any site
    3. Open a couple more tabs
    4. Drag one of the new tabs to the pinned tabs section, drop.

  • Actual result:
    Console error is shown (Shift+F8)

  • Expected result:
    Tab should get pinned

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes
@bbondy bbondy added this to the 0.15.0 milestone Apr 24, 2017
@bbondy bbondy self-assigned this Apr 24, 2017
bbondy added a commit that referenced this issue Apr 24, 2017
@bbondy
Use the correct action name for pinning via drop
ff1b269 
I think what happened here is that everything was converted but new code
was pulled in from a component refactor that moved using the new action
name and not updated during a merge conflict.

Auditors: @bsclifton

Fix #8469
@bbondy bbondy closed this as completed in 0f41941 Apr 24, 2017
bbondy added a commit that referenced this issue Apr 24, 2017
@bbondy
Use the correct action name for pinning via drop
15fe6e6 
I think what happened here is that everything was converted but new code
was pulled in from a component refactor that moved using the new action
name and not updated during a merge conflict.

Auditors: @bsclifton

Fix #8469
@bbondy
Copy link
Member Author

bbondy commented Apr 24, 2017

Thanks @srirambv for finding the error.

@alexwykoff alexwykoff mentioned this issue Apr 25, 2017
Closed
82 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbondy bbondy

Labels
QA/no-qa-needed release-notes/exclude
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
2 participants
@bbondy @luixxiul