Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

React prop-types #8152

Closed
NejcZdovc opened this issue Apr 9, 2017 · 0 comments
Closed

React prop-types #8152

NejcZdovc opened this issue Apr 9, 2017 · 0 comments
Assignees
@NejcZdovc
Labels
dev-setup QA/no-qa-needed release-notes/exclude
Milestone
0.15.0

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Apr 9, 2017 •
edited
Loading

Describe the issue you encountered:
Based on https://facebook.github.io/react/docs/typechecking-with-proptypes.html, we need to add external prop-types library.

We are getting this error now:
"Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead."
@NejcZdovc NejcZdovc added this to the 0.14.2 milestone Apr 9, 2017
@NejcZdovc NejcZdovc self-assigned this Apr 9, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 9, 2017
@NejcZdovc
Fixes depricated prop types, now we use separate npm package
1695bbc 
Resolves brave#8152

Auditors: @bsclifton @bbondy

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Apr 9, 2017
Merged
4 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 10, 2017
@NejcZdovc
Fixes depricated prop types, now we use separate npm package
e9e3f1d 
Resolves brave#8152

Auditors: @bsclifton @bbondy

Test Plan:
bsclifton added a commit that referenced this issue Apr 10, 2017
@bsclifton
Merge pull request #8153 from NejcZdovc/hotfix/#8152-types
73762de 
Fixes deprecated prop types
bsclifton pushed a commit that referenced this issue Apr 10, 2017
@NejcZdovc @bsclifton
Fixes depricated prop types, now we use separate npm package
bfe18b0 
Resolves #8152

Auditors: @bsclifton @bbondy

Test Plan:
bsclifton pushed a commit that referenced this issue Apr 10, 2017
@NejcZdovc @bsclifton
Fixes depricated prop types, now we use separate npm package
eda32b3 
Resolves #8152

Auditors: @bsclifton @bbondy

Test Plan:
@alexwykoff alexwykoff mentioned this issue Apr 14, 2017
Closed
82 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
dev-setup QA/no-qa-needed release-notes/exclude
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
2 participants
@bsclifton @NejcZdovc