Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Multiple homepage not working #7442

Closed
srirambv opened this issue Mar 2, 2017 · 1 comment
Closed

Multiple homepage not working #7442

srirambv opened this issue Mar 2, 2017 · 1 comment
Assignees
@NejcZdovc
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/include settings
Milestone
0.13.5

Comments

@srirambv
Copy link
Collaborator

srirambv commented Mar 2, 2017 •
edited by bsclifton
Loading

Test plan

  1. open preferences
  2. Add multiple sites using %7C and set Brave to start with Homepage
  3. Verify that | is not transformed to %7C (see image below)
  4. Relaunch browser, all sites should now be open in tabs

original issue description

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Reported from community https://community.brave.com/t/multiple-home-pages-error-bug/1481/
    Adding | automatically converts to %7C in homepage textfield

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    0.13.4

  • Steps to reproduce:

    1. Add | in homepage field
    2. Automatically converts to %7C
    3. Add multiple sites using %7C and set Brave to start with Homepage
    4. Relaunch browser, URL contains the entire list of sites with %7C and doesn't load each site in a new tab

  • Actual result:
    Multiple homepage doesnt load

  • Expected result:
    Multiple homepage should load as per what is set

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes, verified on 0.13.3

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    homepage

  • Any related issues:
    cc: @NejcZdovc
    Multiple home page URLs stopped working - "Your file was not found" #6913 Multiple homepages #3110
@srirambv srirambv added this to the 0.13.6 milestone Mar 2, 2017
@srirambv srirambv mentioned this issue Mar 2, 2017
Closed
@NejcZdovc NejcZdovc self-assigned this Mar 2, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 2, 2017
@NejcZdovc
Fixed display for multiplehomepages
8fba23a 
Resolves brave#7442

Auditors: @darkdh

Test Plan:
- described in brave#7442
@NejcZdovc NejcZdovc mentioned this issue Mar 2, 2017
Merged
4 tasks
@bsclifton bsclifton modified the milestones: 0.13.5, 0.13.6 Mar 2, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 2, 2017
@NejcZdovc
Fixed display for multiplehomepages
3e7999c 
Resolves brave#7442

Auditors: @darkdh

Test Plan:
- described in brave#7442
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 2, 2017
@NejcZdovc
Fixed display for multiple homepages
51d0333 
Resolves brave#7442

Auditors: @darkdh

Test Plan:
- described in brave#7442
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 2, 2017
@NejcZdovc
Fixed display for multiple homepages
a0eea16 
Resolves brave#7442

Auditors: @darkdh

Test Plan:
- described in brave#7442
@bsclifton bsclifton added regression and removed bug labels Mar 2, 2017
bsclifton added a commit that referenced this issue Mar 2, 2017
@bsclifton
Merge pull request #7444 from NejcZdovc/hotfix/#7442-multiple
c2d132d 
Fixed display for multiple homepage
@srirambv
Copy link
Collaborator Author

srirambv commented Mar 3, 2017

Working on 0.13.5 RC3

This was referenced Mar 3, 2017
Closed
Closed
Closed
Closed
@srirambv srirambv mentioned this issue Oct 6, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/include settings
Projects
None yet
Milestone
0.13.5
Development

No branches or pull requests
4 participants
@alexwykoff @bsclifton @NejcZdovc @srirambv