You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
chrome.remote.getCurrentWindow().setSize(122, 122)
And you'll see it doesn't resize.
Or alternative steps to reproduce: npm run test -- --grep="offsets from the focused window"
And you'll see it fails, you'll have to remove the this.skip from the test first though.
Note this works in .12.15 but you have to use this code: require('electron').remote.getCurrentWindow().setSize(122, 122)
Once fixed please re-enable the test.
/cc @posix4e, would you mind taking a look since this is introduced in .13?
The text was updated successfully, but these errors were encountered:
This turned out not to be only a problem in the tests. Ubuntu maximizes windows by default when they run so the resize wouldn't work in a maximized state. The fix is just to unmaximize in tests before doing the resize.
Ubuntu maximizes applications by default on first run. Tests should not assume window is not maximized. Resizes don't work when a window is maximized.
Fix#6554
more logging-2
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Steps to reproduce:
chrome.remote.getCurrentWindow().setSize(122, 122)
And you'll see it doesn't resize.
Or alternative steps to reproduce:
npm run test -- --grep="offsets from the focused window"
And you'll see it fails, you'll have to remove the this.skip from the test first though.
Note this works in .12.15 but you have to use this code:
require('electron').remote.getCurrentWindow().setSize(122, 122)
Once fixed please re-enable the test.
/cc @posix4e, would you mind taking a look since this is introduced in .13?
The text was updated successfully, but these errors were encountered: