About pages favicon changes when popup tabs is closed before loading

[srirambv]

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
About pages favicon changes when popup tabs is closed before loading

Expected behavior:
Should not change the favicon of about pages irrespective of when the popup tabs are closed

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 10 x64

• Brave Version (revision SHA):
  Have not seen this issue on 0.12.15, seen only on
  Brave 0.13.0
  rev 0c7a64d

• Steps to reproduce:

  1. Keep any of the about pages open and in a new tab open a webpage which triggers popup tabs
  2. Click on page to trigger popup tab
  3. Close the tab immediately before the popup tab content loads
  4. Repeat step 2-3 three to four time s
  5. About page favicon changes from Brave logo to one of the sites which was supposed to open in the popup tabs
  6. Screenshot 1 shows the effect of closing pocket login page being closed before loading after enabling the extension

• Screenshot if needed:
  
  
  

• Any related issues:
  Please change milestone if required

[bbondy]

I'll take this one, the problem is we get the event in the webview before a frame is actually created, so it puts the icon on the first frame. The fix would be to manage the data in TabHelper and handle fro the browser process.

[bbondy]

Actually that's not needed yet, it is just because it is closed so the frame is removed. Strange we even get that event.

[bbondy]

Test plan: Follow the steps to reproduce in comment 0.

[srirambv]

This is still happening on 0.13.0 RC1

[srirambv]

This is not a release blocker can be moved to 0.13.1 or 0.13.2 if required

[bbondy]

strange it was definitely working at some point, moved to 0.13.1

[bbondy]

it's much reduced from what it used to be, I could reproduce 1 in 4 times before, now only happens once in maybe 30 times for me.

[srirambv]

Still seeing this issue after a while on 0.17.6 on Debian

[kjozwiak]

I noticed this happen when going through the YT feature for hotfix5... Noticed that YT was using the BAT icon.... After I refreshed the page, the normal expected YT icon was displayed... Example:

Using v0.19.93 rev: 25085d0 via Ubuntu 16.04.3 LTS x64.