Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

autofill entry cannot be deleted on restart with Private data option #4818

Closed
luixxiul opened this issue Oct 15, 2016 · 3 comments · Fixed by #4827
Closed

autofill entry cannot be deleted on restart with Private data option #4818

luixxiul opened this issue Oct 15, 2016 · 3 comments · Fixed by #4827
Assignees
@darkdh
Labels
bug feature/autofill QA/checked-macOS QA/checked-Win32
Milestone
0.12.5dev

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: autofill entry cannot be deleted on restart with Private data option. Also clicking these crosses does not remove the entries.

clipboard01

Expected behavior: The entries should be removed on restart

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10
  • Brave Version: 0.12.5 RC1
  • Steps to reproduce:
    1. Add address and credit card
    2. Enable "autofill data" option of Private Data on about:preferences#security
    3. Restart the browser
  • Any related issues:
@luixxiul luixxiul added this to the 0.12.5dev milestone Oct 15, 2016
@bbondy
Copy link
Member

bbondy commented Oct 15, 2016

/cc @darkdh for 0.12.6

@bbondy bbondy modified the milestones: 0.12.6dev, 0.12.5dev Oct 15, 2016
@darkdh
Copy link
Member

darkdh commented Oct 15, 2016 •
edited
Loading

@luixxiul What do you mean "Private Data"?

@luixxiul
Copy link
Contributor Author

If you open about:preferences#security you have the options to select which data should be removed on restart, whose label is "Private Data".

@darkdh darkdh self-assigned this Oct 15, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 15, 2016
@darkdh
Clear state if clear autofill data when shutdown.
a2cec59 
because we won't receive personal-data-changed on shutdown

fix brave#4818

Auditors: @bridiver

Test Plan:
1. Add autofill data entries in about:autofill
2. Turn on clear "Autofill data" when closing brave in about:preferences#security
3. Restart brave
4. There shouldn't be anything left in about:autofill
@darkdh darkdh mentioned this issue Oct 15, 2016
Merged
4 tasks
@bbondy bbondy modified the milestones: 0.12.5dev, 0.12.6dev Oct 15, 2016
bbondy pushed a commit that referenced this issue Oct 15, 2016
@darkdh @bbondy
Clear state if clear autofill data when shutdown.
76e6573 
because we won't receive personal-data-changed on shutdown

fix #4818

Auditors: @bridiver

Test Plan:
1. Add autofill data entries in about:autofill
2. Turn on clear "Autofill data" when closing brave in about:preferences#security
3. Restart brave
4. There shouldn't be anything left in about:autofill
@luixxiul luixxiul mentioned this issue Oct 16, 2016
Closed
This was referenced Oct 16, 2016
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Oct 18, 2016
Closed
102 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
bug feature/autofill QA/checked-macOS QA/checked-Win32
Projects
None yet
Milestone
0.12.5dev
Development

Successfully merging a pull request may close this issue.

Clear state if clear autofill data when shutdown. darkdh/browser-laptop
4 participants
@bbondy @alexwykoff @luixxiul @darkdh