Open link from external application creates new brave window

[jonathansampson]

Did you search for similar issues before submitting this one?

Yes

Describe the issue you encountered:

Brave opens with two identical windows. Clicking a link in Slack, Outlook, or GitHub for Windows demonstrates this. Additionally, running "http://bing.com" from the Run Dialog (with no Brave instance opened) results in two identical windows being opened.

Expected behavior:

When loading a resource, Brave should open at most one Window.

• Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10 (14393)
• Brave Version: 0.12.1
• Steps to reproduce:
  1. Close all instances of Brave
  2. Press Windows+R to open the Run Dialog
  3. Type "http://bing.com" (sans quotes) and press Enter
  4. Note that multiple Brave windows are opened
• Screenshot if needed: N/A
• Any related issues: N/A

[decode-dev]

Cannot reproduce the Issue in Brave 0.12.1 for the both scenarios in Windows (7, 8, 10).

[bridiver]

I found the cause of this issue, but it's going to take a little work to untangle the code because there is a race condition between the url open and the window initialization on startup

[bridiver]

@decode-dev I think the description is a little misleading. The problem is that it opens a new window for the url instead of opening a new tab in one of the existing windows and I have verified the problem, but there is a race condition so it may not always occur.

[bridiver]

also verified this happens on all platforms

[bbondy]

I think this is a dupe of #2959 we should get this one fixed. It restores the old session in window 1 and puts a new session for the new link instead o combining the old one.

[bridiver]

Seems like an additional issue with the window opening as full screen on top of the new tab vs window issue already filed

On Sep 24, 2016, at 10:12 AM, Brian R. Bondy notifications@github.com wrote:

I think this is a dupe of #2959 we should get this one fixed. It restores the old session in window 1 and puts a new session for the new link instead o combining the old one.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

[bsclifton]

+1 from @orschiro via #11098

[srirambv]

+1 from https://community.brave.com/t/brave-not-opening-external-application/14063

[bsclifton]

+1 from both @vrms and @xsilas43 via #13378

[moustachio-belvedere]

Same for me (Windows 7, brave is default browser). I always get 1 brave window with content and one brave window with my homepage (about:blank).

[sakralbar]

I always get two browser windows when I open links from other programs.
Linux Mint 18.3 cinnamon, Brave 0.22.13

[eljuno]

++ from community https://community.brave.com/t/2-windows-open-when-clicking-email-link/15146?u=eljuno

[stefangordon]

I still see this with 0.55.20 Windows 10 - is it tracked elsewhere?

[jonathansampson]

@stefangordon I'm not able to reproduce this with 0.55.20 on Windows 10. Can you describe the steps you're taking to trigger the behavior? A video would be helpful as well if you're able.

[stefangordon]

Hey @jonathansampson -

After making a screen recording I figured out what was going on (well, more or less).

When I click a link I am getting two 0.25.2 Brave instances rather than my 0.55.20 instance. When installing the newer version I guess it did not clean up the old one, and Windows default browser must also be confused (even though 0.55.20 thinks it is the default). I'm sure I can fix this by uninstalling the old version and resetting defaults :) Thanks!

[paulklinkenberg]

Hi there! I experience the same issue on latest Macbook pro with latest OS. The issue is already marked as Closed, but there has not been a Beta or Nightly to test it :-(
Any ideas when this will become available?
Thanks for a great browser!

Oh, by the way, the latest comments refer to a version number "0.55.20". Does that version even exist? Can't seem to find anything like that version on Github... "v0.25.204" being the latest nightly and all.

[bsclifton]

@paulklinkenberg this repo is tracking the old version of Brave (which was based on Muon). The latest version is in the 0.25.x range. The latest version of the NEW browser (at the time of this writing) is going to be 0.58.18. You can download that from https://brave.com/download

If you still experience the issue, you can search for or create an issue in the new repository:
https://github.com/brave/brave-browser