Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

New Tab context menu not needed options #3670

Closed
charbelrami opened this issue Sep 2, 2016 · 3 comments
Closed

New Tab context menu not needed options #3670

charbelrami opened this issue Sep 2, 2016 · 3 comments
Labels
polish Nice to have — usually related to front-end/visual tasks.
Milestone
0.12.1dev

Comments

@charbelrami
Copy link
Contributor

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
'Reload' and 'Clone' are not useful in the context menu of a new tab

Expected behavior:

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Win 10 64
  • Brave Version:
    0.11.6dev
  • Steps to reproduce:
    1. Click the right button on a New Tab
  • Screenshot if needed:
    new_tab_context_menu
  • Any related issues:
@bradleyrichter bradleyrichter added enhancement polish Nice to have — usually related to front-end/visual tasks. labels Sep 3, 2016
@bradleyrichter bradleyrichter added this to the 1.0.0 milestone Sep 3, 2016
@bradleyrichter
Copy link
Contributor

@charbelrami nice catch. thanks!

@bbondy bbondy modified the milestones: 0.12.1dev, 1.0.0 Sep 4, 2016
@cndouglas cndouglas mentioned this issue Sep 4, 2016
Merged
4 tasks
@cndouglas
Copy link

If you don't mind, I already have a patch for this (#3713).

@bbondy bbondy unassigned jkup Sep 5, 2016
@bbondy bbondy removed this from the 0.12.1dev milestone Sep 5, 2016
@bbondy
Copy link
Member

bbondy commented Sep 5, 2016

Actually clone is still a valid operation as well regardless of the current page. Because it clones the full history, you might just want a copy of the history. Reload isn't needed for now, but it should be for example an intermediate page is. New tab should be allowed always.

bbondy added a commit that referenced this issue Sep 12, 2016
@bbondy
Merge pull request #3713 from Liunkae/patch-1
47bf893 
Removed unneeded context menu items (Fix #3670)
@bbondy bbondy added this to the 0.12.1dev milestone Sep 12, 2016
This was referenced Sep 14, 2016
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Sep 14, 2016
Closed
bbondy added a commit that referenced this issue Sep 14, 2016
@bbondy
Always show new tab in tab-context menu
51f654c 
Auditors: @liunkae

Test Plan: Right click on a new tab, the context menu should list new tab and appear correctly.  Then right click on a navigated tab, it should also show new tab and appear correctly. Reload and clone should be missing for the new tab option only

Fix #3670
@alexwykoff alexwykoff mentioned this issue Sep 15, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
polish Nice to have — usually related to front-end/visual tasks.
Projects
None yet
Milestone
0.12.1dev
Development

No branches or pull requests
5 participants
@jkup @bbondy @charbelrami @bradleyrichter @cndouglas