Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

New windows have pinned tab active, instead of New non-pinned tab #13797

Closed
petemill opened this issue Apr 11, 2018 · 3 comments
Closed

New windows have pinned tab active, instead of New non-pinned tab #13797

petemill opened this issue Apr 11, 2018 · 3 comments
Labels
0.22.x-single-webview Issue first seen on single-webview build against v0.22.x branch QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.22.x Release 3 ...

Comments

@petemill
Copy link
Member

Steps to Reproduce

  1. Pin a tab
  2. Open a new window with cmd-n

Actual result:
The tab that has focus in the new window is the pinned tab

Expected result:
The tab that has focus in the new window is the new non-pinned tab

Reproduces how often:
100%

Brave Version

about:brave info:
0.22.108

Reproducible on current live release:
No
@petemill petemill added regression 0.22.x-single-webview Issue first seen on single-webview build against v0.22.x branch labels Apr 11, 2018
@petemill petemill added this to the 0.22.x Release 3 (Beta channel) milestone Apr 11, 2018
@petemill petemill assigned petemill and unassigned petemill Apr 11, 2018
petemill added a commit that referenced this issue Apr 11, 2018
@petemill
Ensure new windows have non-pinned tab active
96fdb81 
Not pinned tab
Fix #13797
@hugobuddel
Copy link
Contributor

The same happens when a tab is dragged out of Brave, or when Brave starts: the rightmost pinned tab gets focus instead of the dragged tab or the new tab.

petemill added a commit that referenced this issue Apr 11, 2018
@petemill
Ensure new windows have non-pinned tab active
0833c6a 
Not pinned tab
Fix #13797
petemill added a commit that referenced this issue Apr 11, 2018
@petemill
Ensure new windows have non-pinned tab active
08207b4 
Not pinned tab
Fix #13797
petemill added a commit that referenced this issue Apr 11, 2018
@petemill
Ensure new windows have non-pinned tab active
2f66dd0 
Not pinned tab
Fix #13797
@petemill
Copy link
Member Author

Should be fixed in 0.22.109

@LaurenWags
Copy link
Member

LaurenWags commented Apr 11, 2018 •
edited by btlechowski
Loading

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.109 5e4846e
  • libchromiumcontent: 65.0.3325.181
  • muon: 6.0.3

Verified on Win7 x64:

  • 0.22.109 5e4846e
  • libchromiumcontent: 65.0.3325.181
  • muon: 6.0.3

Verified on Ubuntu 17.10 x64:
0.22.109 5e4846e
libchromiumcontent: 65.0.3325.181
muon: 6.0.3

petemill added a commit that referenced this issue Apr 30, 2018
@petemill
Ensure new windows have non-pinned tab active
e500e59 
Not pinned tab
Fix #13797
petemill added a commit that referenced this issue Apr 30, 2018
@petemill
Ensure new windows have non-pinned tab active
0bb2848 
Not pinned tab
Fix #13797
petemill added a commit that referenced this issue May 1, 2018
@petemill
Ensure new windows have non-pinned tab active
7ab99e6 
Not pinned tab
Fix #13797
petemill added a commit that referenced this issue May 2, 2018
@petemill
Ensure new windows have non-pinned tab active
df01cfd 
Not pinned tab
Fix #13797
petemill added a commit that referenced this issue May 3, 2018
@petemill
Ensure new windows have non-pinned tab active
34ec812 
Not pinned tab
Fix #13797
petemill added a commit that referenced this issue May 7, 2018
@petemill
Ensure new windows have non-pinned tab active
9f9459c 
Not pinned tab
Fix #13797
petemill added a commit that referenced this issue May 8, 2018
@petemill
Ensure new windows have non-pinned tab active
fc314b1 
Not pinned tab
Fix #13797
petemill added a commit that referenced this issue May 8, 2018
@petemill
Ensure new windows have non-pinned tab active
fe1b2d8 
Not pinned tab
Fix #13797
petemill added a commit that referenced this issue May 9, 2018
@petemill
Ensure new windows have non-pinned tab active
974fe03 
Not pinned tab
Fix #13797
petemill added a commit that referenced this issue May 10, 2018
@petemill
Ensure new windows have non-pinned tab active
7a018fd 
Not pinned tab
Fix #13797
petemill added a commit that referenced this issue May 10, 2018
@petemill
Ensure new windows have non-pinned tab active
99734c7 
Not pinned tab
Fix #13797
petemill added a commit that referenced this issue May 10, 2018
@petemill
Ensure new windows have non-pinned tab active
2781cec 
Not pinned tab
Fix #13797
petemill added a commit that referenced this issue May 11, 2018
@petemill
Ensure new windows have non-pinned tab active
4d111a1 
Not pinned tab
Fix #13797
petemill added a commit that referenced this issue May 11, 2018
@petemill
Ensure new windows have non-pinned tab active
c4f98d9 
Not pinned tab
Fix #13797
petemill added a commit that referenced this issue May 11, 2018
@petemill
Ensure new windows have non-pinned tab active
f61fe1b 
Not pinned tab
Fix #13797
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
0.22.x-single-webview Issue first seen on single-webview build against v0.22.x branch QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.22.x Release 3 (Release Channel)
Development

No branches or pull requests
5 participants
@petemill @hugobuddel @bsclifton @LaurenWags @btlechowski