Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Removing URL doesn't remove the EVC details #13256

Closed
srirambv opened this issue Feb 22, 2018 · 3 comments · Fixed by #13335
Closed

Removing URL doesn't remove the EVC details #13256

srirambv opened this issue Feb 22, 2018 · 3 comments · Fixed by #13335
Labels
0.22.x issue first seen in 0.22.x bug feature/URLbar parity Features which should be supported in Brave since they're supported in other major browsers. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.22.x (Release C...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Feb 22, 2018 •
edited by bsclifton
Loading

Description

Removing URL doesn't remove the EVC details

Test plan / Steps to Reproduce

  1. Clean install 0.21.11
  2. Visit Github.com, ensure the EVC is shown once URL is loaded
  3. Select URL and delete, EVC is still shown

Actual result:
evc

Expected result:
Site EVC should be removed when the URL is removed

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.21.11
V8 6.4.388.41
rev e146cd8
Muon 5.0.5
OS Release 10.0.16299
Update Channel Beta
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 64.0.3282.140

Reproducible on current live release:
N/A

Additional Information

cc: @MargarytaChepiga @bsclifton @diracdeltas
@srirambv srirambv added bug parity Features which should be supported in Brave since they're supported in other major browsers. feature/URLbar 0.21.x issue first seen in 0.21.x labels Feb 22, 2018
@srirambv srirambv added this to the 0.21.x (Beta Channel) milestone Feb 22, 2018
@jasonrsadler jasonrsadler mentioned this issue Feb 27, 2018
Closed
10 tasks
@bsclifton bsclifton added 0.22.x issue first seen in 0.22.x and removed 0.21.x issue first seen in 0.21.x labels Feb 27, 2018
@alexwykoff
Copy link
Contributor

If reviewed by eob it stays in, otherwise pushed to another release.

@jasonrsadler jasonrsadler mentioned this issue Feb 27, 2018
Merged
10 tasks
@diracdeltas
Copy link
Member

PR has been approved

bsclifton added a commit that referenced this issue Feb 27, 2018
@bsclifton
Merge pull request #13335 from jasonrsadler/master
2ceda21 
Fixed issue #13256 - Removing or modifying URL will now hide EVC
bsclifton added a commit that referenced this issue Feb 27, 2018
@bsclifton
Merge pull request #13335 from jasonrsadler/master
be6d2cf 
Fixed issue #13256 - Removing or modifying URL will now hide EVC
This was referenced Mar 22, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator Author

srirambv commented Mar 22, 2018 •
edited by btlechowski
Loading

Verified on Windows x64

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on Ubuntu 10.10 x64

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
0.22.x issue first seen in 0.22.x bug feature/URLbar parity Features which should be supported in Brave since they're supported in other major browsers. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Fixed issue #13256 - Removing or modifying URL will now hide EVC
6 participants
@diracdeltas @alexwykoff @bsclifton @srirambv @LaurenWags @btlechowski