Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark and tabs DND are not working on Windows #12590

Closed
NejcZdovc opened this issue Jan 10, 2018 · 3 comments
Closed

Bookmark and tabs DND are not working on Windows #12590

NejcZdovc opened this issue Jan 10, 2018 · 3 comments
Assignees
@petemill
Labels
0.20.x issue first seen in 0.20.x feature/bookmarks misc/drag-and-drop OS/Windows QA/checked-Win64 QA/test-plan-specified regression release/blocking release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jan 10, 2018 •
edited by bsclifton
Loading

Test plan

  1. Create new folder in the toolbar
  2. Add another folder in this new folder
  3. Try to dnd this folder on the toolbar
  4. Drag and drop should work

Description

Drag and drop in bookmark toolbar is not working on windows anymore.

Steps to Reproduce

  1. Create new folder in the toolbar
  2. Add another folder in this new folder
  3. Try to dnd this folder on the toolbar

Actual result:

dnd is blocked

Expected result:
dnd shouldn't be blocked

Reproduces how often:

100%

Brave Version

about:brave info:

Reproducible on current live release:

Additional Information

More info #12481 (comment)

Related issue #11728
@NejcZdovc NejcZdovc added this to the 0.20.x (Beta Channel) milestone Jan 10, 2018
@NejcZdovc NejcZdovc self-assigned this Jan 10, 2018
@NejcZdovc NejcZdovc mentioned this issue Jan 10, 2018
Closed
@NejcZdovc NejcZdovc added regression 0.20.x issue first seen in 0.20.x labels Jan 10, 2018
@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Jan 10, 2018 •
edited
Loading

As far as I can see this was broken with #10512 where we moved allowDrag one level up and because of that on Windows dnd is not working for bookmarks and tabs

https://github.com/brave/browser-laptop/pull/10512/files#diff-de5d4f1b019deecc5b1926970450546cR610

cc @petemill

@NejcZdovc NejcZdovc mentioned this issue Jan 10, 2018
Closed
@NejcZdovc NejcZdovc removed their assignment Jan 10, 2018
@NejcZdovc NejcZdovc changed the title Bookmark DND is not working on Windows Bookmark and tabs DND are not working on Windows Jan 11, 2018
@bsclifton
Copy link
Member

bsclifton commented Jan 16, 2018 •
edited
Loading

@petemill can you please check out the comment by @NejcZdovc above?

On Windows, anything that is draggable does not have a context menu working, btw

@petemill
Copy link
Member

@bsclifton @NejcZdovc how annoying, I'm on it. 👍

petemill added a commit that referenced this issue Jan 17, 2018
@petemill
Fix: ensure context menus are able to be interacted with when they co…
b337da3 
…ver a title-bar area (via '-webkit-app-region: drag') on Windows

`contextMenuDetail` is a property of a window's state, and not the app state

Fix #12590
@petemill petemill mentioned this issue Jan 17, 2018
Merged
10 tasks
@LaurenWags LaurenWags mentioned this issue Jan 22, 2018
Closed
19 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petemill petemill

Labels
0.20.x issue first seen in 0.20.x feature/bookmarks misc/drag-and-drop OS/Windows QA/checked-Win64 QA/test-plan-specified regression release/blocking release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
4 participants
@petemill @bsclifton @NejcZdovc @srirambv