printToPDF doesn't do anything

[bridiver]

This one doesn't have an easy STR because we only call it from the contribution statement.

[darkdh]

@bridiver, we can use npm run add-simulated-payment-history to generated fake payment history.

[LaurenWags]

Verified using these steps:
Had a profile with 0.19.66 (packaged build) where payments were enabled, closed Brave.
Renamed profile to be brave-development.
Built 0.19.x from source.
Ran npm run add-simulated-payment-history.
Renamed brave-development back to brave.
Opened 0.19.66 (packaged build) again.
Went to about:preferences#payments.
Opened payment history and clicked on a link.
On the new tab that opened with the contribution statement, verified I was prompted to save my statement. Verified I could save a statement. Verified I could cancel saving a statement.

cc @bridiver @darkdh @kjozwiak for confirmation these steps are sufficient for testing.

[srirambv]

Verification fails on Windows
STR

1. Clean install 0.19.66 and enable payments and close the browser
2. Build from source and run npm run add-simulated-payments-history 50
3. Copied the ledger-state.json from %appdata%/brave-development to %appdata%/brave
4. Launch the browser, click on payment history button
5. Click on any entry, opens a new tab with the contribution statement
6. No save prompt shown for the contribution statement tab

[srirambv]

@bridiver @darkdh any steps that I missed?

[darkdh]

@LaurenWags, @srirambv you are both right.
I just verified printToPDF doesn't work on Windows.

[srirambv]

@kjozwiak confirmed save prompt shown on Linux. Seems to be still an issue only on Windows

cc: @darkdh

[luixxiul]

I also confirmed it worked for me on Debian.

[bbondy]

Moving to hotfix 3

[bbondy]

Moving to hotfix 4

[srirambv]

Works fine on 0.19.72 for Windows. Prompts save file option when opening the payment statement

[kjozwiak]

@LaurenWags, can you double check and make sure this is working on macOS? I want to make sure the new fix hasn't regressed the other platforms as well. I'll check on Ubuntu.

[LaurenWags]

Still works on MacOS @kjozwiak