Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Add user-friendly title for about:blank
Browse files Browse the repository at this point in the history
Auditors: @bsclifton, @bradleyrichter, @srirambv

Fix #5764

Test Plan:

* Set new tab opens with my homepage
* Clear the homepage field
* Open a new tab
* New tab title must be about:blank
* Navigate to a site on that tab and long press the back navigation button. Title inside contextMenu should be "about:blank"
  • Loading branch information
cezaraugusto committed Nov 22, 2016
1 parent f91d389 commit 6a139a5
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 0 deletions.
16 changes: 16 additions & 0 deletions app/extensions/brave/about-blank.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<!DOCTYPE html>
<!-- This Source Code Form is subject to the terms of the Mozilla Public
- License, v. 2.0. If a copy of the MPL was not distributed with this
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<html>
<head>
<meta charset="utf-8">
<meta name="availableLanguages" content="">
<meta name="defaultLanguage" content="en-US">
<title data-l10n-id="aboutBlank"></title>
<script src='js/about.js'></script>
<script src="ext/l20n.min.js" async></script>
<link rel="localization" href="locales/{locale}/preferences.properties">
</head>
<body />
</html>
1 change: 1 addition & 0 deletions app/extensions/brave/locales/en-US/preferences.properties
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ startsWithOptionHomePage=my home page
startsWithOptionNewTabPage=the new tab page
newTabMode=A new tab shows
newTabBlank=blank
aboutBlank=about:blank
newTabNewTabPage=the new tab page
newTabHomePage=my home page
newTabDefaultSearchEngine=default search engine
Expand Down

0 comments on commit 6a139a5

Please sign in to comment.