fix autosuggest error on file:/// URLs

fix #8967
brave · May 19, 2017 · 6443918 · 6443918
1 parent da5b398
commit 6443918
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/app/common/lib/suggestion.js b/app/common/lib/suggestion.js
@@ -234,8 +234,8 @@ const getSortByDomain = (userInputLower, userInputHost) => {
     // any count or frequency calculation.
     // Note that for parsed URLs that are not complete, the pathname contains
     // what the user is entering as the host and the host is null.
-    const host1 = s1.parsedUrl.host || s1.parsedUrl.pathname
-    const host2 = s2.parsedUrl.host || s2.parsedUrl.pathname
+    const host1 = s1.parsedUrl.host || s1.parsedUrl.pathname || s1.location || ''
+    const host2 = s2.parsedUrl.host || s2.parsedUrl.pathname || s2.location || ''
 
     let pos1 = host1.indexOf(userInputHost)
     let pos2 = host2.indexOf(userInputHost)

diff --git a/test/unit/app/common/lib/suggestionTest.js b/test/unit/app/common/lib/suggestionTest.js
@@ -250,6 +250,9 @@ describe('suggestion unit tests', function () {
       it('simple domain gets matched higher', function () {
         assert(this.sort('https://www.google.com', 'https://www.google.com/extra') < 0)
       })
+      it('does not throw error for file:// URL', function () {
+        assert(this.sort('https://google.com', 'file://') < 0)
+      })
     })
     describe('getSortForSuggestions', function () {
       describe('with url entered as path', function () {