Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump braces from 3.0.2 to 3.0.3 #159

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 17, 2024

Bumps braces from 3.0.2 to 3.0.3.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 17, 2024
Copy link

[puLL-Merge] - micromatch/braces@3.0.2..3.0.3

Description

This pull request contains a variety of changes across multiple files, primarily aimed at updating the ESLint configuration, improving code readability, and making the codebase more robust. The main motivation for the change seems to be enhancing code quality through more granular and consistent ESLint rules.

Possible Issues

  1. Increased Linting Rules Granularity: The PR changes many linting rules from errors (2) to warnings (1), which might reduce the strictness of enforced code quality standards unless the team prefers warnings over errors for these cases.
  2. Parsing Adjustment: In parse.js, there's an update to constants, which changes the MAX_LENGTH used for validation. This might have downstream effects that could potentially lead to unexpected behavior if not thoroughly tested.
Changes

Changes

.eslintrc.json

  • Simplified structure by combining extends elements and refining rule severity levels.
  • Reorganized rules to improve readability and consistency.
    + "array-bracket-newline": [1, "consistent"],
    + "arrow-parens": [1, "as-needed"],
    + "no-case-declarations": 1,

.verb.md

  • Updated comments to refine markdown structure and add consistency.
    -**Default**: `65,536`
    +**Default**: `10,000`

README.md

  • Modified markdown formatting for better consistency and readability.
    -| **Pattern**                 | **braces**         | **[minimatch][]**           |
    +| **Pattern**                 | **braces**          | **[minimatch][]**            |

LICENSE

  • Extended the license from 2018 to the present.

Security Hotspots

None identified in the changes suggested by this PR.

Changes

Changes

bench/index.js

  • Improved string literal formatting.
    -  process.stdout.write(`\u001b[G  ${e.target}${newline ? `\n` : ''}`);
    +  process.stdout.write(`\u001b[G  ${e.target}${newline ? '\n' : ''}`);

examples/expand.js

  • Removed unnecessary parse method import and commented out unused code.

index.js

  • Changed let to const where applicable.
  • Simplified looping logic in braces.create function.

lib/compile.js

  • Switched from let to const where applicable.
  • Simplified logic and added consistency in handling compile actions.

lib/constants.js

  • Updated MAX_LENGTH from 1024 * 64 to 10000 for improved efficiency.

lib/expand.js

  • Switched from let to const where applicable, and added stricter validations.

lib/parse.js

  • Changed let to const.
  • Simplified bracket and brace parsing logic to be more consistent.

lib/stringify.js

  • Simplified method signatures and prefixed utility functions.

lib/utils.js

  • Prefixed utility functions for consistency and updated array handling logic for optimization.

package.json

  • Updated dependencies to include the latest versions for better stability.

test files

  • Added and updated tests to handle new edge cases and to reflect changes in ESLint rules.

This PR overall aims to maintain consistency, improve performance, and ensure the robustness of the overall codebase through various enhancements and stricter, though more consistent, linting rules.

@onyb
Copy link
Member

onyb commented Jan 7, 2025

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 7, 2025

Looks like braces is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Jan 7, 2025
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/braces-3.0.3 branch January 7, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file puLL-Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant