Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default ad notifications per hour from 5 to 10 #243

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

tmancey
Copy link
Contributor

@tmancey tmancey commented Mar 25, 2022

Change default ads per hour from 5 to 10 for new users or users who have not previously changed their default value. See AdServing/default_ad_notifications_per_hour

@tmancey tmancey self-assigned this Mar 25, 2022
@tmancey tmancey requested a review from a team as a code owner March 25, 2022 15:14
@tmancey tmancey merged commit eb1a9c2 into main Mar 25, 2022
@tmancey tmancey deleted the change_default_ad_notifications_per_hour_to_10 branch March 25, 2022 20:14
@btlechowski
Copy link

Verification passed on

Brave 1.36.119 Chromium: 99.0.4844.83 (Official Build) (64-bit)
Revision b11086e62d7c1a44b0942ac5568d22a425c7ae35-refs/branch-heads/4844_74@{#5}
OS Ubuntu 18.04 LTS

Tested on staging

default value update

Before the seed update
image

After seed update:
image

User changed value

Before the seed update
image

After seed update:
image

Copy link
Contributor

@moritzhaller moritzhaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants