Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rollout percentage for DayZeroStudyWindows #1156

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Update rollout percentage for DayZeroStudyWindows #1156

merged 1 commit into from
Aug 12, 2024

Conversation

DJAndries
Copy link
Collaborator

No description provided.

@DJAndries DJAndries requested a review from a team as a code owner August 6, 2024 16:12
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024 •
edited
Loading

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1156.
    Android: Set the command line to --variations-pr=1156 in debug menu, restart the browser.
    iOS: Set Variations PR to 1156 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1156@880b2650e3d678fd1e01d9e19db25739062723f6
Uploaded Fri, 09 Aug 2024 04:28:31 GMT
PR commit 8186823
Base commit 4f91a05
Merge commit 880b265
Serial number 9eb09fe08375444ce12111bc4a942c65

goodov
goodov reviewed Aug 6, 2024
View reviewed changes
@DJAndries DJAndries force-pushed the update-day-zero-windows branch from 0c3a4d6 to 8186823 Compare August 8, 2024 18:10
kjozwiak
kjozwiak approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into production approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit a1acbfe Aug 12, 2024
7 checks passed
@kjozwiak kjozwiak deleted the update-day-zero-windows branch August 12, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@goodov goodov goodov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DJAndries @kjozwiak @goodov