Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Updating Rewards icon assets #335

Merged
merged 1 commit into from
Jan 4, 2019
Merged

Updating Rewards icon assets #335

merged 1 commit into from
Jan 4, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Jan 4, 2019

Related: brave/brave-browser#1825

Changes

Updates icon assets appearing on the welcome page, deletes no longer used assets

Preview:
screen shot 2019-01-03 at 9 05 15 pm

Test plan

Link / storybook path to visual changes

https://brave-ui-ohzypr6l6.now.sh

Integration

  • Does this contain changes to src/components or src/

    • Will you publish to npm immediately after this PR, or wait until sometime in the future?
    • Incompatible API change to something existing (major version increase)
    • Adding new backwards-compatible functionality? (minor version increase)
    • Fixing a bug backwards-compatibly? (patch version increase)
  • Does this contain changes to src/features for brave-core?

    • Are there non backwards-compatible changes required for brave-core? Do not merge until brave-core PR is approvable. Link to brave-core PR:
    • Will you create brave-core PR to update to this commit after it is merged?
    • Wants uplift to brave-core feature branch?
      • When uplift-approved, merge to brave-core-0.VV.x feature branch
      • Create additional brave-core PRs for each feature branch to update commit

@ryanml ryanml self-assigned this Jan 4, 2019
@ryanml ryanml requested a review from NejcZdovc January 4, 2019 04:10
@ryanml ryanml merged commit d011438 into brave:master Jan 4, 2019
@ryanml ryanml deleted the asset-update branch January 4, 2019 19:07
ryanml added a commit that referenced this pull request Jan 7, 2019
Updating Rewards icon assets
NejcZdovc pushed a commit that referenced this pull request Jan 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants