Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

No Bug: Update xcode version on CI to 15.1 #8253

Closed
wants to merge 12 commits into from
Closed

No Bug: Update xcode version on CI to 15.1 #8253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a395ab0
No Bug: Update xcode version on CI to 15
iccub Oct 16, 2023
a65b7b0
update to 15.0.1
iccub Nov 24, 2023
a10a7c4
Fix devices.
iccub Nov 24, 2023
0a60ba2
disable failing tests.
iccub Nov 24, 2023
815daf8
ipad fix
iccub Nov 25, 2023
278718b
[temp] disable iPads tests see if CI does not time out
iccub Nov 27, 2023
886d0a4
Update xcode to 15.1
iccub Jan 2, 2024
a21e992
Update device to 17.1
iccub Jan 2, 2024
9d76443
device 17.2
iccub Jan 2, 2024
2550359
Skip broken test
iccub Jan 2, 2024
e1ee9aa
disable testContentBlockerManager
iccub Jan 2, 2024
885a6c4
Restore iPad test suite
iccub Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
# The XCode version to use. If you want to update it please refer to this document:
# https://docs.github.com/en/actions/reference/specifications-for-github-hosted-runners#supported-software
# and set proper version.
XCODE_VERSION: "14.3.1"
XCODE_VERSION: "15.1"

steps:
- name: Select XCode
Expand Down
11 changes: 9 additions & 2 deletions fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ platform :ios do
run_tests(
project: "App/Client.xcodeproj",
scheme: "Debug",
devices: options[:test_all] ? ["iPhone 14 (16.4)", "iPhone 14 (17.0)"] : ["iPhone 14 (16.4)"],
# Note: At the moment Xcode 15.0.1 on GH Actions does not support older sim versions.
devices: options[:test_all] ? ["iPhone 14 (17.2)"] : ["iPhone 14 (17.2)"],
code_coverage: true,
ensure_devices_found: true,
skip_testing: [
Expand All @@ -53,6 +54,9 @@ platform :ios do
"ClientTests/HttpCookieExtensionTest/testSaveAndLoadCookie",
"ClientTests/UserAgentTests",
"ClientTests/CachedAdBlockEngineTests/testPerformance",
"ClientTests/ScriptExecutionTests/testSiteStateListenerScript",
"ClientTests/FarblingProtectionHelperTests/testGivenTheSameRandomManagerThenSameFakePluginData",
"ClientTests/ContentBlockerManagerTests/testContentBlockerManager",
"DataTests",
"BraveWalletTests/ManageSiteConnectionsStoreTests/testRemoveAllPermissions",
"BraveWalletTests/ManageSiteConnectionsStoreTests/testRemovePermissions",
Expand All @@ -65,13 +69,16 @@ platform :ios do
"BraveWalletTests/SendTokenStoreTests/testUDAddressResolutionTokenChange",
"BraveWalletTests/TransactionConfirmationStoreTests/testPrepareERC20Approve",
"BraveWalletTests/TransactionConfirmationStoreTests/testPrepareTransactionNotOnSelectedNetwork",
"BraveWalletTests/AccountActivityStoreTests/testUpdateEthereumAccount",
"BraveSharedTests/NSURLExtensionsTests/testBugzillaURLDomain",
]
)

run_tests(
project: "App/Client.xcodeproj",
scheme: "Debug",
devices: options[:test_all] ? ["iPad (10th generation) (16.4)", "iPad (10th generation) (17.0)"] : ["iPad (10th generation) (16.4)"],
# Note: At the moment Xcode 15.0.1 on GH Actions does not support older sim versions.
devices: options[:test_all] ? ["iPad (10th generation) (17.2)"] : ["iPad (10th generation) (17.2)"],
code_coverage: true,
ensure_devices_found: true,
skip_testing: [
Expand Down
Loading