Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #8092: Use correct histogram name for NTP-SI P3A total count answer #8094

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix #8092: Use correct histogram name for NTP-SI P3A total count answer #8094

merged 1 commit into from
Sep 20, 2023

Conversation

kylehickinson
Copy link
Collaborator

Summary of Changes

This pull request fixes #8092

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson added this to the 1.58 milestone Sep 19, 2023
@kylehickinson kylehickinson requested a review from a team as a code owner September 19, 2023 19:10
@kylehickinson kylehickinson enabled auto-merge (squash) September 19, 2023 19:26
@kylehickinson kylehickinson merged commit 2d88456 into development Sep 20, 2023
@kylehickinson kylehickinson deleted the ntp-si-p3a-key-fix branch September 20, 2023 11:09
iccub pushed a commit that referenced this pull request Sep 20, 2023
@kylehickinson @iccub
Fix #8092: Use correct histogram name for NTP-SI P3A total count answ…
24b1b11 
…er (#8094)
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
@kylehickinson
Fix brave/brave-ios#8092: Use correct histogram name for NTP-SI P3A t…
0721696 
…otal count answer (brave/brave-ios#8094)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DJAndries DJAndries DJAndries approved these changes

@iccub iccub iccub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.58
Development

Successfully merging this pull request may close these issues.

Fix NTP-SI P3A total count metric name
3 participants
@kylehickinson @DJAndries @iccub