Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #5723: Solana transaction support in Transaction Parser #5737

Merged
merged 7 commits into from
Jul 26, 2022

Conversation

StephenHeaps
Copy link
Contributor

@StephenHeaps StephenHeaps commented Jul 22, 2022

Summary of Changes

  • Support the 3 Solana transaction types in the TransctionParser
  • Fix AccountActivityStore using hardcoded .eth coin type, causing issues when connected to other networks / viewing Solana accounts
  • Fix AssetDetailStore using hardcoded .eth coin type, causing issues displaying transactions

This pull request fixes #5723

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  1. Create a send transaction for SOL token
  2. Create a send transaction for any non-SOL token on Solana (Spl Token)
  3. Verify transactions show up in account detail / account activity for the respective account that made the transaction
  4. Verify transactions show up in the asset detail for the respective tokens (SOL and the non-SOL token)

You can use Solana explorer to verify transaction display.

Screenshots:

#5723 - account details #5723 - asset details SOL #5723 - asset details STEPHEN

SOL send transaction on explorer
STEPHEN send transaction on explorer
(transactions from screenshots)

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@StephenHeaps StephenHeaps added this to the 1.42 milestone Jul 22, 2022
@StephenHeaps StephenHeaps requested review from kylehickinson, nuo-xu and a team July 22, 2022 17:41
@StephenHeaps StephenHeaps self-assigned this Jul 22, 2022
@StephenHeaps StephenHeaps force-pushed the transaction-parser-solana branch 2 times, most recently from f446d2a to 6707470 Compare July 25, 2022 15:12
@StephenHeaps StephenHeaps force-pushed the transaction-parser-solana branch from 6707470 to b893848 Compare July 25, 2022 17:08
@StephenHeaps StephenHeaps marked this pull request as ready for review July 25, 2022 17:08
@StephenHeaps StephenHeaps requested a review from nuo-xu July 25, 2022 17:10
@StephenHeaps StephenHeaps merged commit 526cfcf into development Jul 26, 2022
@StephenHeaps StephenHeaps deleted the transaction-parser-solana branch July 26, 2022 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Solana transactions in TransactionParser
2 participants