Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

No bug: Fix Wallet SF Symbols references #5535

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

StephenHeaps
Copy link
Contributor

Summary of Changes

ref: #5477

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Tap / hold on any truncated address in wallet to see context menu showing clipboard image beside 'copy address'
Dapp request

Screenshots:

suggested network view panel view

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@StephenHeaps StephenHeaps requested review from kylehickinson, nuo-xu and a team June 16, 2022 19:39
@StephenHeaps StephenHeaps self-assigned this Jun 16, 2022
@StephenHeaps StephenHeaps merged commit 9014131 into development Jun 16, 2022
@StephenHeaps StephenHeaps deleted the wallet-symbols-bundle branch June 16, 2022 20:58
soner-yuksel pushed a commit that referenced this pull request Jun 22, 2022
* Fix a couple wallet SF Symbol references
* Fix sizing of clipboard image in menu on `SuggestedNetworkView`
@iccub iccub added this to the 1.40 milestone Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants