Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on Android caused by regression PR9799 #9851

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Aug 25, 2021

Resolves brave/brave-browser#17693

Fixes regression on Android tests caused by brave/brave-browser#17693 .

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

npm run test -- brave_unit_tests Release --target_os=android --target_arch=x86

@AlexeyBarabash AlexeyBarabash added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Aug 25, 2021
@AlexeyBarabash AlexeyBarabash self-assigned this Aug 25, 2021
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AlexeyBarabash AlexeyBarabash merged commit b80d70b into master Aug 25, 2021
@AlexeyBarabash AlexeyBarabash deleted the fix_android_test_17693 branch August 25, 2021 16:23
@AlexeyBarabash AlexeyBarabash added this to the 1.30.x - Nightly milestone Aug 25, 2021
mkarolin pushed a commit that referenced this pull request Aug 25, 2021
Fix tests on Android caused by regression PR9799
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android test regression after brave-core#9799
2 participants