Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new WebGL extensions blocking logic #8831

Merged
merged 1 commit into from
May 25, 2021
Merged

Implement new WebGL extensions blocking logic #8831

merged 1 commit into from
May 25, 2021

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented May 17, 2021 •
edited
Loading

Resolves brave/brave-browser#15882

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@pilgrim-brave pilgrim-brave requested a review from a team as a code owner May 17, 2021 20:33
@pilgrim-brave pilgrim-brave self-assigned this May 17, 2021
@pilgrim-brave pilgrim-brave requested a review from bridiver May 17, 2021 20:33
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_webgl_extensions branch 6 times, most recently from 5607cae to 0667528 Compare May 24, 2021 14:58
bridiver
bridiver approved these changes May 24, 2021
View reviewed changes
Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with changes discussed in DM for getSupportedExtensions

@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_webgl_extensions branch from 0667528 to adf5ac5 Compare May 24, 2021 19:51
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_webgl_extensions branch from adf5ac5 to 337c93f Compare May 24, 2021 21:48
@pilgrim-brave
Copy link
Contributor Author

CI failures are unrelalted.

@pilgrim-brave pilgrim-brave merged commit daa84af into master May 25, 2021
@pilgrim-brave pilgrim-brave deleted the mpilgrim_webgl_extensions branch May 25, 2021 04:43
@pilgrim-brave pilgrim-brave added this to the 1.27.x - Nightly milestone May 25, 2021
@stephendonner stephendonner mentioned this pull request May 28, 2021
Closed
@pilgrim-brave
Copy link
Contributor Author 

<!DOCTYPE html>
<html>
    <head>
        <title>WebGL getSupportedExtensions() test</title>
        <meta charset="utf-8">
    </head>
    <body>
        <pre id="p" style="width:600px; white-space:pre-wrap"></pre>
        <canvas id="test" width="8" height="8"></canvas>
        <script>
         var canvas = document.getElementById("test");
         var gl = canvas.getContext("webgl");
         var ext_list = gl.getSupportedExtensions();
         document.getElementById("p").innerText = ext_list.join(", ");
        </script>
    </body>
</html>

If Brave Shields is off, or Brave Shields is on and fingerprinting is off, or Brave Shields is on and fingerprinting is default, this test page will yield a result similar to

ANGLE_instanced_arrays, EXT_blend_minmax, EXT_color_buffer_half_float, EXT_disjoint_timer_query, EXT_float_blend, EXT_frag_depth, EXT_shader_texture_lod, EXT_texture_compression_rgtc, EXT_texture_filter_anisotropic, WEBKIT_EXT_texture_filter_anisotropic, EXT_sRGB, OES_element_index_uint, OES_fbo_render_mipmap, OES_standard_derivatives, OES_texture_float, OES_texture_float_linear, OES_texture_half_float, OES_texture_half_float_linear, OES_vertex_array_object, WEBGL_color_buffer_float, WEBGL_compressed_texture_s3tc, WEBKIT_WEBGL_compressed_texture_s3tc, WEBGL_compressed_texture_s3tc_srgb, WEBGL_debug_renderer_info, WEBGL_debug_shaders, WEBGL_depth_texture, WEBKIT_WEBGL_depth_texture, WEBGL_draw_buffers, WEBGL_lose_context, WEBKIT_WEBGL_lose_context, WEBGL_multi_draw

If Brave Shields is on and fingerprinting is maximum, output should be

WEBGL_debug_renderer_info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver bridiver approved these changes

Assignees

@pilgrim-brave pilgrim-brave

Labels
feature/shields
Projects
None yet
Milestone
1.27.x - Release
Development

Successfully merging this pull request may close these issues.

Fingerprinting 3.0: WebGL Debugging Followups
2 participants
@pilgrim-brave @bridiver