Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #7346 from brave/sync_no_identity_manager" #7470

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

AlexeyBarabash
Copy link
Contributor

This reverts commit 1df4f68, reversing
changes made to ecb32e7.

Resolves brave/brave-browser#13234

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@AlexeyBarabash AlexeyBarabash requested review from a team as code owners December 17, 2020 15:11
@AlexeyBarabash AlexeyBarabash self-assigned this Dec 17, 2020
@AlexeyBarabash AlexeyBarabash added the CI/skip Do not run CI builds (except noplatform) label Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows debug build is broken by b-c PR 7346
3 participants