Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run git cl format without '--full' by default #7402

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Dec 10, 2020

fix brave/brave-browser#13123

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. add some formatting errors (ex: extra whitespace) to a file with lots of formatting errors like components/brave_ads/browser/ads_service_impl.cc
  2. npm run lint should fail
  3. npm run format should fix only the lines that you modified. exception: if you modified an include directive, it will fix all the directives.
  4. npm run format --full should fix the rest of the format errors in the file

Copy link
Collaborator

@zenparsing zenparsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay on this - looks good!

@diracdeltas diracdeltas merged commit 7e397a5 into master Dec 11, 2020
@diracdeltas diracdeltas deleted the fix/lint-format branch December 11, 2020 19:02
@diracdeltas diracdeltas added this to the 1.20.x - Nightly milestone Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'npm run format' should only run on diffed lines by default
2 participants