Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Brave Ads to reduce tight coupling #7153

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Refactor Brave Ads to reduce tight coupling #7153

merged 1 commit into from
Nov 18, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Nov 16, 2020

Resolves brave/brave-browser#12558

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Contributor

@moritzhaller moritzhaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed on screen share - LGTM!

@tmancey tmancey force-pushed the issues/12558 branch 6 times, most recently from 90acac4 to 7060ed3 Compare November 17, 2020 18:03
@tmancey tmancey added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Nov 17, 2020
@tmancey tmancey force-pushed the issues/12558 branch 7 times, most recently from b4ae2cf to 1e31174 Compare November 18, 2020 15:39
@tmancey tmancey removed CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Nov 18, 2020
@tmancey
Copy link
Collaborator Author

tmancey commented Nov 18, 2020

Restarting CI for all platforms as previously Android was failing. After further investigation, this was due to two of the unit tests having the same test suite name. This was only an issue on Android.

@tmancey
Copy link
Collaborator Author

tmancey commented Nov 18, 2020

CI failed for known rewards tests

@tmancey tmancey merged commit f33fb26 into master Nov 18, 2020
@tmancey tmancey deleted the issues/12558 branch November 18, 2020 22:22
@tmancey tmancey added this to the 1.19.x - Nightly milestone Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Brave Ads to reduce tight coupling
3 participants