Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adblock-rust-ffi #6658

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Update adblock-rust-ffi #6658

merged 1 commit into from
Sep 17, 2020

Conversation

antonok-edm
Copy link
Collaborator

Resolves brave/brave-browser#11744

Submitter Checklist:

Test Plan:

Visit https://www.rhmodern.com/catalog/product/product.jsp?productId=prod14970086&categoryId=cat7150028 - the large product image should load and display a sofa, rather than the old behavior where it renders as a gray square.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@antonok-edm antonok-edm added the dependencies Pull requests that update a dependency file label Sep 16, 2020
@antonok-edm antonok-edm self-assigned this Sep 16, 2020
Copy link
Contributor

@pes10k pes10k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though just wondering, why not update to the most recent 0.3.3 version?

@antonok-edm
Copy link
Collaborator Author

@pes10k it is technically the v0.3.3 release - one of the side effects of using git revision hashes in Cargo.toml is that the version fields end up being purely cosmetic, and I just hadn't updated the "version" field in adblock-rust-ffi to match. The code is the same though.

@antonok-edm antonok-edm merged commit cee2df1 into master Sep 17, 2020
@antonok-edm antonok-edm deleted the update-adblock-rust-ffi branch September 17, 2020 19:04
@antonok-edm antonok-edm added this to the 1.16.x - Nightly milestone Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix breakage on some sites that use addthis scripts
2 participants