Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Brave Ads page classification scores from locally persisted diagnostic log #6420

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Aug 13, 2020

Resolves brave/brave-browser#11220

Submitter Checklist:

Test Plan:

  • Confirm Event log for page classification scores is not logged in the diagnostic log
  • Confirm when viewing an ad the event is logged in the diagnostic log
  • Confirm when clicking an ad the event is logged in the diagnostic log
  • Confirm when dismissing an ad the event is logged in the diagnostic log
  • Confirm when an ad times-out the event is logged in the diagnostic log

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey requested a review from NejcZdovc August 13, 2020 15:51
@tmancey tmancey self-assigned this Aug 13, 2020
@tmancey
Copy link
Collaborator Author

tmancey commented Aug 14, 2020

CI failed due to known speed reader browser test

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Brave Ads page classification scores from locally persisted diagnostic log
2 participants