Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds total price/amount line item to trade preview (Gemini) #6094

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Jul 15, 2020

Fixes brave/brave-browser#10756

Screen Shot 2020-07-15 at 1 18 15 PM

Submitter Checklist:

Test Plan:

Defined in issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.13.x - Nightly milestone Jul 15, 2020
@ryanml ryanml requested review from bbondy and emerick July 15, 2020 19:38
@ryanml ryanml self-assigned this Jul 15, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just had one comment

@ryanml ryanml changed the title Adds total price line item to trade preview (Gemini) Adds total price/amount line item to trade preview (Gemini) Jul 15, 2020
@ryanml
Copy link
Contributor Author

ryanml commented Jul 16, 2020

CI failure to due to known ads test failures

@ryanml ryanml merged commit 054b20a into master Jul 16, 2020
@ryanml ryanml deleted the fix-10756 branch July 16, 2020 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Show estimated conversion value in confirm trade window
2 participants