Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buffer overflow in AudioBuffer::copyFromChannel #5427

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Apr 30, 2020

Resolves brave/brave-browser#9552

Submitter Checklist:

Test Plan:

  1. Visit this url-> https://immediate-maroon-playground.glitch.me/
  2. Click "Crash" button. If tab crashes with "Aw snap" message, bug exists.
  3. If nothing visible happens, bug is fixed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@pilgrim-brave pilgrim-brave requested a review from bridiver as a code owner April 30, 2020 14:08
@pilgrim-brave
Copy link
Contributor Author

Test is here: #5428

Separated because the test is blocked on a separate (seemingly unrelated) issue.

@pilgrim-brave
Copy link
Contributor Author

Merging with @bridiver's approval even though it failed CI because it looks like it's an unrelated network error on Mac. It passed on all other platforms and passed locally on my Mac.

@kjozwiak
Copy link
Member

kjozwiak commented May 2, 2020

Reproduced the issue on macOS 10.15.4 x64 using the following build:

Brave | 1.10.22 Chromium: 81.0.4044.129 (Official Build) nightly (64-bit)
--- | ---
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | macOS Version 10.15.4 (Build 19E287)

Screen Shot 2020-05-02 at 2 23 52 AM

Verification PASSED on macOS 10.15.4 x64 using the following build:

Brave | 1.10.24 Chromium: 81.0.4044.129 (Official Build) nightly (64-bit)
--- | ---
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | macOS Version 10.15.4 (Build 19E287)

Couldn't reproduce the crash using the STR outlined via #5427 (comment).

@BrendanEich
Copy link
Member

dst[i] = dst[i] * fudge_factor; \
No one loves *= any more. (I am old C hacker.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in CopyFromChannelMethod
5 participants