Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads promotion types with no expiration are still valid #4964

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Mar 17, 2020

Resolves brave/brave-browser#8612
Resolves brave/brave-browser#8586

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@emerick emerick added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Mar 17, 2020
@emerick emerick requested a review from NejcZdovc as a code owner March 17, 2020 14:09
@emerick emerick self-assigned this Mar 17, 2020
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, didn't test it on android

@emerick emerick force-pushed the unclaimable-ad-grants-android branch from 6992db3 to b31e2b5 Compare March 17, 2020 17:21
@emerick emerick merged commit 5f7549b into master Mar 17, 2020
@emerick emerick deleted the unclaimable-ad-grants-android branch March 17, 2020 18:08
@emerick emerick added this to the 1.8.x - Nightly milestone Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
2 participants