[iOS] - Cleanup UI and Strings

[Brandon-T]

Summary

• Cleanup VPN, AIChat, and RecentlyClosedTabs UI
• Cleanup Wallet Strings from AIChat (not sure how they got there)
• Fix warnings in Package.swift

Resolves brave/brave-browser#44298

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

[github-actions]

[puLL-Merge] - brave/brave-core@27858

Description

This PR includes multiple UI improvements and code cleanup across the Brave iOS app, primarily focused on standardizing font styles and simplifying view modifiers. It also removes several localization files from the AIChat component.

Changes

Changes

1. LeoAssetsPlugin.swift

• Simplified guard statement syntax by removing unused variable assignment

2. UI Components Updates

• Standardized font styling by replacing .body.weight(.semibold) with .headline across multiple views
• Simplified background modifiers by using .capsule shape instead of Capsule()
• Removed redundant alignment parameters in frame modifiers
• Consolidated view modifiers

3. Localization

• Removed BraveWallet.strings files for multiple locales:
  • ca, de, en, es, fr, id-ID, it, ja, ko-KR, ms, nb, pl, pt-BR, ru, sv, tr, uk, zh-TW, zh

sequenceDiagram
    participant UI as UI Components
    participant Style as Style System
    participant Plugin as LeoAssetsPlugin
    
    UI->>Style: Replace custom font weights
    Style-->>UI: Return .headline style
    UI->>Style: Simplify background modifiers
    Style-->>UI: Apply .capsule shape
    Plugin->>Plugin: Simplify guard statement

Loading

Possible Issues

1. The removal of localization files might impact the app's internationalization if these files are being referenced elsewhere in the codebase.
2. Changing from custom font weights to predefined styles (.headline) might cause subtle visual differences in the UI that need to be validated against design specifications.

[brave-builds]

Released in v1.78.5