Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] - Fix memory-leaks found in Search Controller and Search Suggestions (uplift to 1.76.x) #27850

Merged
merged 1 commit into from
Feb 27, 2025
Merged

[iOS] - Fix memory-leaks found in Search Controller and Search Suggestions (uplift to 1.76.x) #27850

merged 1 commit into from
Feb 27, 2025
+2 −2

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Feb 27, 2025 •
edited by kjozwiak
Loading

Uplift of #27521
Resolves brave/brave-browser#43769

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner February 27, 2025 16:46
@brave-builds brave-builds added this to the 1.76.x - Release milestone Feb 27, 2025
@brave-builds brave-builds self-assigned this Feb 27, 2025
@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Feb 27, 2025
kjozwiak
kjozwiak approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.76.x approved 👍

@kjozwiak kjozwiak merged commit c118b07 into 1.76.x Feb 27, 2025
17 checks passed
@kjozwiak kjozwiak deleted the pr27521_bugfix/SearchMemoryLeak_1.76.x branch February 27, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.76.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @Brandon-T