-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not removed shields settings with empty primary pattern. #27819
Conversation
Maybe we can do a follow-up to move the default value for Shields settings to be a profile pref instead |
4c070b3
to
111e6b9
Compare
raw_ptr<Profile> profile_ = nullptr; | ||
base::flat_map<ContentSettingsType, std::vector<ContentSettingPatternSource>> | ||
defaults_; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a bit questionable. Is this the right fix here? Shouldn't we instead migrate those bogus rules in content settings and let the cleanup logic work as intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, this is what @ShivanKaul said above.
I guess we can have this PR as a quick workaround for the really annoying problem, but we should eventually fix this and store the default state in pref.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Released in v1.78.6 |
Resolves brave/brave-browser#28319
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: