Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize Sonnet/Haiku wording #27785

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Generalize Sonnet/Haiku wording #27785

merged 1 commit into from
Feb 25, 2025

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Feb 24, 2025

Sonnet recently came out with 3.7 but our UI is hardcoded to 3.5. This generalizes to Sonnet 3. We already did that for Haiku.

Resolves brave/brave-browser#44195

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bbondy bbondy requested review from a team as code owners February 24, 2025 22:12
@bbondy bbondy requested a review from yrliou February 24, 2025 22:20
@@ -151,7 +151,7 @@ const std::vector<mojom::ModelPtr>& GetLeoModels() {

auto model = mojom::Model::New();
model->key = "chat-claude-sonnet";
model->display_name = "Claude 3.5 Sonnet";
model->display_name = "Claude 3 Sonnet";
Copy link
Member

@diracdeltas diracdeltas Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bbondy this may actually cause more confusion because Claude 3 Sonnet itself is an older model released by Anthropic, and it might make people think that we are using that instead of the latest. https://docs.anthropic.com/en/docs/about-claude/models/all-models (claude-3-sonnet-20240229, still available)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace with Claude Sonnet maybe?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to add to the confusion, claude itself claims to be Sonnet 3 from feb 2024 as opposed to a newer version https://bravesoftware.slack.com/archives/C04KPE0BUDU/p1740437228702079

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree either Claude Sonnet, or stick with 3.7 and keep updating it

@bbondy
Copy link
Member Author

bbondy commented Feb 24, 2025

Keeping it without a version number sgtm. I'll update.

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

@bbondy bbondy changed the title Generalize Sonnet 3.5 to Sonnet 3 wording Generalize Sonnet/Haiku wording Feb 24, 2025
@bbondy bbondy merged commit 0e55cde into master Feb 25, 2025
18 checks passed
@bbondy bbondy deleted the claude-3-7 branch February 25, 2025 13:45
@bbondy bbondy added this to the 1.77.x - Nightly milestone Feb 25, 2025
brave-builds added a commit that referenced this pull request Feb 25, 2025
@brave-builds
Copy link
Collaborator

Released in v1.77.65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generalize Sonnet 3.5 wording to Sonnet 3
7 participants