-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize Sonnet/Haiku wording #27785
Conversation
@@ -151,7 +151,7 @@ const std::vector<mojom::ModelPtr>& GetLeoModels() { | |||
|
|||
auto model = mojom::Model::New(); | |||
model->key = "chat-claude-sonnet"; | |||
model->display_name = "Claude 3.5 Sonnet"; | |||
model->display_name = "Claude 3 Sonnet"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bbondy this may actually cause more confusion because Claude 3 Sonnet itself is an older model released by Anthropic, and it might make people think that we are using that instead of the latest. https://docs.anthropic.com/en/docs/about-claude/models/all-models (claude-3-sonnet-20240229, still available)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace with Claude Sonnet
maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to add to the confusion, claude itself claims to be Sonnet 3 from feb 2024 as opposed to a newer version https://bravesoftware.slack.com/archives/C04KPE0BUDU/p1740437228702079
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree either Claude Sonnet, or stick with 3.7 and keep updating it
Keeping it without a version number sgtm. I'll update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strings
++
Released in v1.77.65 |
Sonnet recently came out with 3.7 but our UI is hardcoded to 3.5. This generalizes to Sonnet 3. We already did that for Haiku.
Resolves brave/brave-browser#44195
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: