[CodeHealth] Simplifying json parsing - pt.3

[cdesouza-chromium]

This PR simplifies JSON reading in several places by:

- Using `base::JSONReader::ReadDict`
- Using `base::test::ParseJson*`

This changes aim to make the checks around the parsing and its expectations simpler to read.

Resolves

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

[zenparsing]

Rewards 👍

[AlexeyBarabash]

sync ++

[SergeyZhukovsky]

++

[github-actions]

[puLL-Merge] - brave/brave-core@27732

Description

This PR updates the codebase to use the newer base::JSONReader::ReadDict API instead of base::JSONReader::Read. This change simplifies JSON parsing code by directly returning a base::Value::Dict instead of a base::Value that needs to be checked for dictionary type.

Changes

Changes

By filename:

1. components/brave_rewards/core/engine/endpoints/

   • Updated multiple files to use ReadDict instead of Read
   • Removed redundant dictionary type checks
   • Simplified access to dictionary values by using the returned dict directly

2. components/brave_shields/content/browser/

   • Updated ad_block_engine.cc to use ReadDict and simplified parsing logic

3. components/brave_vpn/

   • Updated JSON parsing in multiple files to use ReadDict
   • Simplified value access patterns
   • Updated test cases to use new API

4. components/brave_wallet/browser/

   • Updated blockchain_list_parser.cc to use ReadDict
   • Simplified parsing logic and removed redundant type checks

sequenceDiagram
    participant Code
    participant JSONReader
    participant Dict
    
    Note over Code,Dict: Old Flow
    Code->>JSONReader: Read()
    JSONReader-->>Code: base::Value
    Code->>Code: Check if is_dict()
    Code->>Code: GetDict()
    
    Note over Code,Dict: New Flow
    Code->>JSONReader: ReadDict()
    JSONReader-->>Code: base::Value::Dict
    Code->>Dict: Direct dictionary access

Loading

[brave-builds]

Released in v1.77.64