Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update html5ever/markup5ever for speedreader/kuchikiki #27719

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

DJAndries
Copy link
Collaborator

@DJAndries DJAndries commented Feb 19, 2025

Resolves brave/brave-browser#44226

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Feb 19, 2025
@DJAndries DJAndries force-pushed the update-html5ever branch 5 times, most recently from b5f236e to 487cbeb Compare February 21, 2025 20:37
@DJAndries DJAndries changed the base branch from master to wdp-patterns-url-switch February 21, 2025 20:40
@DJAndries DJAndries force-pushed the wdp-patterns-url-switch branch from 7112461 to dd51620 Compare February 21, 2025 21:45
@DJAndries DJAndries force-pushed the wdp-patterns-url-switch branch from dd51620 to 4947e1b Compare February 21, 2025 22:54
Base automatically changed from wdp-patterns-url-switch to master February 22, 2025 00:29
@DJAndries DJAndries marked this pull request as ready for review February 25, 2025 19:55
@DJAndries DJAndries requested review from a team and bridiver as code owners February 25, 2025 19:55
Copy link
Contributor

[puLL-Merge] - brave/brave-core@27719

Here's my analysis of this pull request:

Description

This PR makes several significant changes to the codebase, primarily focusing on:

  1. Updating JSON parsing methods across various components to use more modern/safer APIs
  2. Enhancing the onboarding experience in iOS
  3. Updating localization strings and performance test configurations
  4. Updating Rust dependencies for various components

The motivation appears to be modernizing code patterns and improving user experience during onboarding.

Possible Issues

  1. The test profile changes might not capture all edge cases for performance testing
  2. GetLeoModels model name changes could cause backwards compatibility issues with existing data

Security Hotspots

  1. JSON parsing changes use base::JSONReader::ReadDict which is a safer API but there should be careful testing around error handling in these paths as they touch sensitive areas like wallet operations
  2. Translation feature could potentially expose user data through insecure content - should verify content security policy is properly applied
Changes

Changes

By filename:

  • components/brave_rewards/: Updates JSON parsing to use base::JSONReader::ReadDict across multiple files
  • components/brave_vpn/: Updates region name mapping and JSON parsing logic
  • components/brave_wallet/: Updates blockchain list parser implementation
  • ios/brave-ios/: Major refactor of onboarding experience with new UI components
  • tools/perf/: Updates performance test configurations and profiles

Let me know if you would like me to expand on any part of this analysis.```mermaid
sequenceDiagram
participant User
participant Onboarding
participant BraveCore
participant TranslateService

User->>Onboarding: Starts app first time
Onboarding->>BraveCore: Check environment
BraveCore-->>Onboarding: Environment info
Onboarding->>User: Show welcome screen
User->>Onboarding: Interacts with steps
Onboarding->>TranslateService: Configure translation
TranslateService-->>User: Ready for translation
Onboarding->>User: Complete setup
</details>

<!-- Generated by claude-3-5-sonnet-20241022 -->

@DJAndries DJAndries merged commit de09c28 into master Feb 26, 2025
18 checks passed
@DJAndries DJAndries deleted the update-html5ever branch February 26, 2025 02:24
@github-actions github-actions bot added this to the 1.77.x - Nightly milestone Feb 26, 2025
@brave-builds
Copy link
Collaborator

Released in v1.77.68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) puLL-Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use alternate scraping library for native Web Discovery
3 participants