Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor Rust scraper #27662

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Vendor Rust scraper #27662

merged 2 commits into from
Feb 26, 2025

Conversation

DJAndries
Copy link
Collaborator

@DJAndries DJAndries commented Feb 14, 2025

Resolves brave/brave-browser#44226

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Feb 14, 2025
Copy link
Contributor

Chromium major version is behind target branch (133.0.6943.54 vs 134.0.6998.15). Please rebase.

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 18, 2025
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 19, 2025
@DJAndries DJAndries changed the base branch from master to update-html5ever February 19, 2025 03:36
@DJAndries DJAndries force-pushed the update-html5ever branch 2 times, most recently from a71c9be to de5f6a4 Compare February 21, 2025 02:42
@DJAndries DJAndries force-pushed the update-html5ever branch 2 times, most recently from 2c80905 to b5f236e Compare February 21, 2025 19:18
@DJAndries DJAndries marked this pull request as ready for review February 25, 2025 19:55
@DJAndries DJAndries requested review from a team and bridiver as code owners February 25, 2025 19:55
Base automatically changed from update-html5ever to master February 26, 2025 02:24
@DJAndries DJAndries merged commit 540bbe6 into master Feb 26, 2025
16 checks passed
@DJAndries DJAndries deleted the wdp-switch-scraper branch February 26, 2025 02:24
@github-actions github-actions bot added this to the 1.77.x - Nightly milestone Feb 26, 2025
DJAndries added a commit that referenced this pull request Feb 26, 2025
@brave-builds
Copy link
Collaborator

Released in v1.77.68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use alternate scraping library for native Web Discovery
3 participants