-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ads] RichNTT: Android #27645
[ads] RichNTT: Android #27645
Conversation
Chromium major version is behind target branch (133.0.6943.54 vs 134.0.6998.15). Please rebase. |
8e189c5
to
42569fa
Compare
fbb6db3
to
0ef68e4
Compare
4c02a83
to
78d1c83
Compare
380b677
to
89049cb
Compare
components/ntp_background_images/browser/view_counter_service.cc
Outdated
Show resolved
Hide resolved
Approved (see comments). Thanks |
@bridiver on desktop, we use a Web UI to display new tab pages. On Android, however, there is no Web UI implementation. Instead, Android overlays a native view over a web contents view. The native view displays the background image, Brave Stats, and Brave News. When the user navigates to a URL, the native view is hidden, revealing the web contents view and its HTML content. To display rich media HTML alongside Brave Stats and Brave News, we use a ThinWebView to render the HTML behind these overlays. |
4a589a5
to
deadbd5
Compare
@@ -0,0 +1,16 @@ | |||
# Copyright (c) 2025 The Brave Authors. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is under brave_new_tab_ui in components, but not in browser https://github.com/brave/brave-core/pull/27645/files#diff-f72ebad5725bed17e104d5245827d8d7cfdee3b6b9f1c7f122af3555e6ddd48c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to components/new_tab_takeover
directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code owner ok
[puLL-Merge] - brave/brave-core@27645 Here's my review of the PR: DescriptionThis PR adds support for rich media wallpapers in Brave's New Tab Page on Android. It introduces a new WebUI component called "New Tab Takeover" that can display HTML content behind the standard New Tab Page overlays (Brave Stats and Brave News). The motivation is to enable more interactive sponsored content in the wallpaper area. Security Hotspots
ChangesChangesBy filename:
The key flow is that when a rich media wallpaper is detected, a WebView is initialized to load and display the content, while maintaining the standard NTP UI overlays.```mermaid
|
Released in v1.78.4 |
The PR introduces
NewTabTakeover
WebUI which does the following:<SponsoredRichMediaBackground>
react componentchrome://new-tab-takeover
NewTabTakeover
webUI is loaded on Android NTP usingThinWebView
wrapped insideFrameLayout
.Currently
NewTabTakeover
web ui is used on Android only, because Desktop implementation uses New Tab Page Web UI and doesn't need additional WebUI.Security review: https://github.com/brave/reviews/issues/1795
Desktop implementation was done in: #27466
Resolves brave/brave-browser#43513
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Test the functionality basing on RichNTT spec: https://docs.google.com/document/d/14kFstJbrsYZyFmZcTAQac195riiinQoVAU1Dzk1e2dE/edit?tab=t.0#heading=h.skhkv2wammbc