Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] New Onboarding UI refresh #27605

Merged
merged 3 commits into from
Feb 25, 2025
Merged

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Feb 10, 2025

This alters the new "welcome focus" onboarding design to match the new refreshed version and implements the iPad column design.

This also updates the DesignSystem SwiftUI button styles to match the most up to date Figma designs (updated radius + minimum heights, updated colors in outline style)

Resolves brave/brave-browser#43883
Resolves brave/brave-browser#44184

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Set region to new onboarding available region (UK/JP), and install fresh
  • Verify basic designs:

Designs: https://www.figma.com/design/FiluJhwOjucQL4iGLmVZLW/iOS-Onboarding?node-id=5107-8391
Figma Previews: https://www.figma.com/proto/FiluJhwOjucQL4iGLmVZLW/iOS-Onboarding?page-id=5107%3A8391&node-id=5160-20103&p=f&t=y2JeZPZxQaysKkJc-0&scaling=min-zoom&content-scaling=fixed&starting-point-node-id=5160%3A20102&show-proto-sidebar=1 (note the iPhone, iPad - Portrait, iPad - Landscape pages for different layouts)

  • Verify multi-tasking on iPad still shows correctly
  • Verify different font sizes render correctly

@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Feb 10, 2025
@kylehickinson kylehickinson self-assigned this Feb 10, 2025
@kylehickinson kylehickinson requested a review from a team as a code owner February 10, 2025 21:21
@kylehickinson kylehickinson force-pushed the ios-new-onboarding-ui-refresh branch from 062c169 to cbab19e Compare February 11, 2025 14:14
@ViewBuilder func makeActions(continueHandler: @escaping () -> Void) -> Actions
}

extension [any OnboardingStep] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Might be more clear to explicitly use Array<any OnboardingStep>. But just a nit and can be ignored anyway.

Copy link
Contributor

Chromium major version is behind target branch (133.0.6943.54 vs 134.0.6998.15). Please rebase.

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 18, 2025
@kylehickinson kylehickinson force-pushed the ios-new-onboarding-ui-refresh branch from cbab19e to 8077940 Compare February 18, 2025 17:42
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 18, 2025
@kylehickinson kylehickinson force-pushed the ios-new-onboarding-ui-refresh branch from 8077940 to 5eda0ed Compare February 19, 2025 21:09
This alters the new "welcome focus" onboarding design to match the new refreshed version and implements the iPad column design.

This also updates the DesignSystem SwiftUI button styles to match the most up to date Figma designs (updated radius + minimum heights, updated colors in outline style)
@kylehickinson kylehickinson force-pushed the ios-new-onboarding-ui-refresh branch from 5eda0ed to 39ee721 Compare February 25, 2025 14:46
Copy link
Contributor

[puLL-Merge] - brave/brave-core@27605

Description

This PR significantly refactors the onboarding experience in the iOS Brave browser by introducing a new modular onboarding system. The changes replace the existing focus onboarding implementation with a more flexible and maintainable architecture using SwiftUI.

Changes

Changes

By file/component:

Onboarding Architecture:

  • Introduced new OnboardingController and OnboardingRootView as core components
  • Created an OnboardingStep protocol to standardize step creation
  • Added environment variables for layout styles and dependencies
  • Implemented responsive layouts (fullscreen, inset, columnInset)

Onboarding Steps:

  • Added BlockInterruptionsOnboardingStep
  • Added DefaultBrowserOnboardingStep
  • Added P3AOptInOnboardingStep
  • Each step follows a consistent pattern with title, graphic and actions

UI Components:

  • Added BraveAppIcon component
  • Updated BraveButtonStyle with improved sizing and styling
  • Added BraveOutlineButtonStyle
  • New splash screen implementation

Asset Changes:

  • Added new Brave wordmark SVG
  • Updated background images
  • Removed unused fonts (Poppins)
  • Updated various image assets

Integration:

  • Updated BrowserViewController to use new onboarding system
  • Removed FocusOnboardingFonts registration
  • Updated callout presentations
sequenceDiagram
    participant U as User
    participant BVC as BrowserViewController
    participant OC as OnboardingController
    participant OS as OnboardingStep
    
    U->>BVC: Launches App
    BVC->>OC: Creates OnboardingController
    OC->>OS: Initializes Steps
    OC-->>U: Shows Splash Screen
    U->>OS: Interacts with Step
    OS-->>OC: Reports Step Completion
    OC->>OS: Shows Next Step
    OS-->>U: Shows Completion
    OC-->>BVC: Dismisses Onboarding
Loading

Possible Issues

  1. Region-specific onboarding flows might need additional testing as there are checks for isNewOnboardingRegion
  2. Dynamic type and accessibility support should be thoroughly tested across all new components
  3. The splash screen animation timing might need adjustment based on device performance

Note: This appears to be a major refactor of the onboarding system, so thorough testing across different devices and configurations would be recommended before deployment.

@kylehickinson kylehickinson merged commit 369cbd1 into master Feb 25, 2025
18 checks passed
@kylehickinson kylehickinson deleted the ios-new-onboarding-ui-refresh branch February 25, 2025 18:34
@github-actions github-actions bot added this to the 1.77.x - Nightly milestone Feb 25, 2025
@brave-builds
Copy link
Collaborator

Released in v1.77.66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 puLL-Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] UK/JP Onboarding: Update set default title and subtitle copy Refresh upcoming onboarding UI
3 participants