-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] New Onboarding UI refresh #27605
Conversation
062c169
to
cbab19e
Compare
ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+Callout.swift
Show resolved
Hide resolved
ios/brave-ios/Sources/Onboarding/WelcomeFocus/OnboardingSplashView.swift
Show resolved
Hide resolved
@ViewBuilder func makeActions(continueHandler: @escaping () -> Void) -> Actions | ||
} | ||
|
||
extension [any OnboardingStep] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Might be more clear to explicitly use Array<any OnboardingStep>
. But just a nit and can be ignored anyway.
Chromium major version is behind target branch (133.0.6943.54 vs 134.0.6998.15). Please rebase. |
cbab19e
to
8077940
Compare
8077940
to
5eda0ed
Compare
This alters the new "welcome focus" onboarding design to match the new refreshed version and implements the iPad column design. This also updates the DesignSystem SwiftUI button styles to match the most up to date Figma designs (updated radius + minimum heights, updated colors in outline style)
5eda0ed
to
39ee721
Compare
[puLL-Merge] - brave/brave-core@27605 DescriptionThis PR significantly refactors the onboarding experience in the iOS Brave browser by introducing a new modular onboarding system. The changes replace the existing focus onboarding implementation with a more flexible and maintainable architecture using SwiftUI. ChangesChangesBy file/component: Onboarding Architecture:
Onboarding Steps:
UI Components:
Asset Changes:
Integration:
sequenceDiagram
participant U as User
participant BVC as BrowserViewController
participant OC as OnboardingController
participant OS as OnboardingStep
U->>BVC: Launches App
BVC->>OC: Creates OnboardingController
OC->>OS: Initializes Steps
OC-->>U: Shows Splash Screen
U->>OS: Interacts with Step
OS-->>OC: Reports Step Completion
OC->>OS: Shows Next Step
OS-->>U: Shows Completion
OC-->>BVC: Dismisses Onboarding
Possible Issues
Note: This appears to be a major refactor of the onboarding system, so thorough testing across different devices and configurations would be recommended before deployment. |
Released in v1.77.66 |
This alters the new "welcome focus" onboarding design to match the new refreshed version and implements the iPad column design.
This also updates the DesignSystem SwiftUI button styles to match the most up to date Figma designs (updated radius + minimum heights, updated colors in outline style)
Resolves brave/brave-browser#43883
Resolves brave/brave-browser#44184
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Designs: https://www.figma.com/design/FiluJhwOjucQL4iGLmVZLW/iOS-Onboarding?node-id=5107-8391
Figma Previews: https://www.figma.com/proto/FiluJhwOjucQL4iGLmVZLW/iOS-Onboarding?page-id=5107%3A8391&node-id=5160-20103&p=f&t=y2JeZPZxQaysKkJc-0&scaling=min-zoom&content-scaling=fixed&starting-point-node-id=5160%3A20102&show-proto-sidebar=1 (note the
iPhone
,iPad - Portrait
,iPad - Landscape
pages for different layouts)