Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect word count for sync #27450

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

fuchenshi
Copy link
Contributor

@fuchenshi fuchenshi commented Feb 1, 2025

This PR fixes the incorrect word count that the user may see when viewing or entering the sync code when setting up sync.

Before:

Screen.Recording.2025-02-01.at.08.55.28.mov

After:

Screen.Recording.2025-02-01.at.08.56.40.mov

Resolves brave/brave-browser#43635

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#43635

@fuchenshi fuchenshi force-pushed the fix-sync-code-word-count branch from d95fd29 to 0bb1b8f Compare February 7, 2025 03:36
@fuchenshi
Copy link
Contributor Author

I did a force push to replace the commit with one that has a signature.

Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good
thanks @fuchenshi for the contributing

CI runs at #27558

@AlexeyBarabash
Copy link
Contributor

CI run #27558 is green

@AlexeyBarabash
Copy link
Contributor

It needs to be uplifted to beta and stable.

@bsclifton
Copy link
Member

Admin merging. Nice work @fuchenshi! ❤️

@bsclifton bsclifton merged commit aa12bfa into brave:master Feb 7, 2025
4 checks passed
@bsclifton bsclifton added this to the 1.77.x - Nightly milestone Feb 7, 2025
brave-builds added a commit that referenced this pull request Feb 7, 2025
brave-builds added a commit that referenced this pull request Feb 7, 2025
@brave-builds
Copy link
Collaborator

Released in v1.77.26

@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.77.26 Chromium: 133.0.6943.54 (Official Build) nightly (64-bit)
-- | --
Revision | b659cfb092f8c82ea07dad4b7f4f38b6193bf49f
OS | Windows 11 Version 24H2 (Build 26100.2894)

Using the STR/Cases outlined via #27450 (comment) & brave/brave-browser#43635 (comment), ensured that the Word count was working as expected as per the following:

Ensuring that the correct Word count is being displayed via Sync Chain Code

Previous/Updated Profile New Profile
oldProfile newProfile

Ensuring that the correct Word count is being when entering Sync Chain Code manually

Recording.2025-02-09.213616.mp4

kjozwiak pushed a commit that referenced this pull request Feb 10, 2025
kjozwiak pushed a commit that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Word count may be incorrect when setting up sync
5 participants