-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect word count for sync #27450
Conversation
d95fd29
to
0bb1b8f
Compare
I did a force push to replace the commit with one that has a signature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good
thanks @fuchenshi for the contributing
CI runs at #27558
CI run #27558 is green |
It needs to be uplifted to |
Admin merging. Nice work @fuchenshi! ❤️ |
Released in v1.77.26 |
Verification PASSED on
Using the STR/Cases outlined via #27450 (comment) & brave/brave-browser#43635 (comment), ensured that the Ensuring that the correct
|
Previous/Updated Profile |
New Profile |
---|---|
![]() |
![]() |
Ensuring that the correct Word count
is being when entering Sync Chain Code
manually
Recording.2025-02-09.213616.mp4
Uplift of #27450 (squashed) to beta
Uplift of #27450 (squashed) to release
This PR fixes the incorrect word count that the user may see when viewing or entering the sync code when setting up sync.
Before:
Screen.Recording.2025-02-01.at.08.55.28.mov
After:
Screen.Recording.2025-02-01.at.08.56.40.mov
Resolves brave/brave-browser#43635
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
See brave/brave-browser#43635