Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unreadable text from prominent button (uplift to 1.68.x) #24331

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Fixed unreadable text from prominent button (uplift to 1.68.x) #24331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions chromium_src/ui/views/controls/button/md_text_button.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,8 +277,10 @@ void MdTextButton::SetLoading(bool loading) {
void MdTextButton::UpdateTextColor() {
MdTextButtonBase::UpdateTextColor();

// Use explicitely set color instead of our default colors.
if (explicitly_set_normal_color()) {
// Use explicitely set color instead of our default colors except for
// prominent style. As we have specific bg color for prominent, need to use
// our text color for this style.
if (style_ != ui::ButtonStyle::kProminent && explicitly_set_normal_color()) {
return;
}

Expand Down
Loading