Simplify customization of WebUIBubbleManager #23049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce155c5 to
c1b225a
Compare
mkarolin
reviewed
Apr 16, 2024
chromium_src/chrome/browser/ui/views/bubble/webui_bubble_dialog_view.h
Outdated
Show resolved
Hide resolved
mkarolin
approved these changes
Apr 16, 2024
6870df6 to
dc4e3a4
Compare
dc4e3a4 to
c2daa7a
Compare
bridiver
approved these changes
Apr 16, 2024
darkdh
approved these changes
Apr 16, 2024
mkarolin
pushed a commit
that referenced
this pull request
May 5, 2024
Simplify customization of WebUIBubbleManager
This was referenced May 5, 2024
mkarolin
pushed a commit
that referenced
this pull request
May 8, 2024
Simplify customization of WebUIBubbleManager
kjozwiak
pushed a commit
that referenced
this pull request
May 8, 2024
* Merge pull request #23049 from brave/ksmith-webui-bubble-mgr Simplify customization of WebUIBubbleManager * Merge pull request #22936 from brave/cr125 Upgrade from Chromium 124 to Chromium 125. * NTP drive module was renamed to file suggestion. Chromium change: https://chromium.googlesource.com/chromium/src/+/1af2f445d25a6 commit 1af2f445d25a6f2e12984418df7b9a0bd09d4523 Author: Riley Tatum <rtatum@google.com> Date: Mon Apr 8 18:55:34 2024 +0000 [NTP] Rename drive module to file suggestion for cleaner reuse of code This change is helping to prepare for another source for file suggestions to be added to the NTP. The other file suggestion source will have the same UX; therefore, it would be best to reuse as much code as possible. Code that can be used across both sources for the module, are changed to use the term "file_suggestion" instead of "drive". Code that is specific to the Drive source keeps the name "drive". This shouldn't change any functionality. It is just meant to make the reuse of this code cleaner. I left v1 of the module largely alone, since extra source support will not be added for the older version of modules . Bug: 329897261 * Merge pull request #23429 from brave/sko/spt-resurrect Fix SharedPinnedTab functionality * TabStripModel::DetachWebContentsAtForInsertion was removed. Chromium change: https://source.chromium.org/chromium/chromium/src/+/afdf1e54a8ef45bfd22ecabfea0012da22bba6a3 commit afdf1e54a8ef45bfd22ecabfea0012da22bba6a3 Author: Erik Chen <erikchen@chromium.org> Date: Mon Apr 15 20:56:17 2024 +0000 Remove TabStripModel::DetachWebContentsAtForInsertion. This CL is a refactor with no intended behavior change. This CL removes callers of DetachWebContentsAtForInsertion. This also allows TabModel::RemoveContents to become private. Bug: 1476012 * Disables crashing upstream unit tests. * Merge pull request #23441 from brave/maxk-fix-bookmarks-folder-color [cr125 follow up] Fixes bookmarks folder color in the side panel. * Merge pull request #23497 from brave/bookmarks_panel_checkboux Fixed bookmarks panel checkbox colors * Restore .rustfmt.toml patch accidentally removed by cr124 bump. --------- Co-authored-by: Kevin Smith <zenparsing@gmail.com> Co-authored-by: Sangwoo Ko <sko@brave.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#37366
Summary of changes:
WebUIBubbleManagerintended to support dialog view customization have been removed.BraveWebUIBubbleManagerclass has been removed.WebUIBubbleDialogViewthat sets the bubble corner radius in the constructor.Note that this change also gives the tab search bubble a 16px corner radius:
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: