Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Search result attribution on iOS #21974

Merged
merged 3 commits into from
Feb 23, 2024
Merged

[ads] Search result attribution on iOS #21974

merged 3 commits into from
Feb 23, 2024

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented Feb 9, 2024

Resolves brave/brave-browser#33469

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Test case 1

  • Enable ShouldAlwaysRunBraveAdsService feature
  • Enable ShouldSupportSearchResultAds feature
  • Enable ShouldAlwaysTriggerBraveSearchResultAdEvents feature
  • Make sure that Brave Ads service is started
  • Trigger search result ad on search.brave.com
  • Check that search result ad served event was triggered in ads service. There should be [ads] Served search result ad with placement id log message
  • Check that search result ad viewed event was triggered in ads service. There should be [ads] Viewed search result ad with placement id log message
  • Click an ad and stay in the opened page for some time
  • Check that search result ad clicked event was triggered in ads service. There should be [ads] Clicked search result ad with placement id log message
  • Check that landed event was triggered in ads service. There should be [ads] Landed on page for <URL> log message
  • Do an ad conversion. Conversion URL can be found in ad metadata
  • Check that conversion event was triggered in ads service. There should be [ads] Successfully added click conversion for search_result_ad log message

Test case 2

  • Enable ShouldAlwaysRunBraveAdsService feature
  • Disable ShouldSupportSearchResultAds feature
  • Enable ShouldAlwaysTriggerBraveSearchResultAdEvents feature
  • Make sure that Brave Ads service is started
  • Trigger search result ad on search.brave.com
  • Check that search result ad served event wasn't triggered.
  • Check that search result ad viewed event wasn't triggered.
  • Check that search result ad clicked event wasn't triggered.

Test case 3

  • Enable ShouldSupportSearchResultAds feature
  • Enable ShouldAlwaysRunBraveAdsService feature
  • Enable ShouldAlwaysTriggerBraveSearchResultAdEvents feature
  • Make sure that Brave Ads service is started
  • Join Brave Rewards
  • Make sure that we cannot get ad on search.brave.com
  • Check that search result ad served event wasn't triggered.
  • Check that search result ad viewed event wasn't triggered.

@aseren aseren requested a review from a team as a code owner February 9, 2024 01:16
@aseren aseren requested a review from tmancey February 9, 2024 01:16
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Please see comment)

@aseren aseren force-pushed the issues/33469 branch 2 times, most recently from e062f42 to 04316b0 Compare February 12, 2024 21:08
@aseren aseren requested a review from tmancey February 12, 2024 21:09
@aseren aseren changed the title [ads] Add search result ad event call for iOS [ads] Trigger search result ad viewed event on iOS Feb 12, 2024
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@aseren aseren changed the title [ads] Trigger search result ad viewed event on iOS [ads] Trigger search result ad viewed/clicked event on iOS Feb 15, 2024
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++ (See comment)

@aseren aseren changed the title [ads] Trigger search result ad viewed/clicked event on iOS [ads] Search result attribution on iOS Feb 23, 2024
@aseren aseren merged commit 8cbf958 into master Feb 23, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ads] Unify iOS search result attribution
4 participants