-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ads] Search result attribution on iOS #21974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Please see comment)
e062f42
to
04316b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++ (See comment)
Resolves brave/brave-browser#33469
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Test case 1
ShouldAlwaysRunBraveAdsService
featureShouldSupportSearchResultAds
featureShouldAlwaysTriggerBraveSearchResultAdEvents
feature[ads] Served search result ad with placement id
log message[ads] Viewed search result ad with placement id
log message[ads] Clicked search result ad with placement id
log message[ads] Landed on page for <URL>
log message[ads] Successfully added click conversion for search_result_ad
log messageTest case 2
ShouldAlwaysRunBraveAdsService
featureShouldSupportSearchResultAds
featureShouldAlwaysTriggerBraveSearchResultAdEvents
featureTest case 3
ShouldAlwaysTriggerBraveSearchResultAdEvents
feature