Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hides expiry date for ads (uplift to 0.64.x) #2193

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Apr 10, 2019

Uplift of #2182

UI PR: brave/brave-ui#445

@NejcZdovc NejcZdovc added this to the 0.64.x - Dev milestone Apr 10, 2019
@NejcZdovc NejcZdovc requested a review from a team April 10, 2019 19:11
@NejcZdovc NejcZdovc self-assigned this Apr 10, 2019
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NejcZdovc before approving the following PR into 0.64.x, need to make sure that the following as been checked:

@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Apr 12, 2019

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR. (linter error is not related to this PR)
  • You have tested your change on Nightly.
  • The PR milestones match the branch they're landing to.

@NejcZdovc NejcZdovc requested a review from kjozwiak April 12, 2019 10:52
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 0.64.x approved after deliberating with @rebron and @srirambv. As per today's Ads/BR meeting, this is something we want uplifted into 0.63.x.

Please make ensure that all the correct labels are being used and that the appropriate issue is moved into the correct milestone.

@NejcZdovc NejcZdovc merged commit cc959e9 into 0.64.x Apr 15, 2019
@NejcZdovc NejcZdovc deleted the expiry-ads-64 branch April 15, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants