-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add primary language metric #21355
Add primary language metric #21355
Conversation
ea6b034
to
8b94803
Compare
8b94803
to
68baa1b
Compare
68baa1b
to
2023dc4
Compare
2023dc4
to
613433b
Compare
613433b
to
1062166
Compare
[puLL-Merge] - brave/brave-core@21355 DescriptionThe pull request appears to focus on refactoring and renaming of various components within the ChangesChangesbrowser/brave_local_state_prefs.cc
browser/browser_context_keyed_service_factories.cc
browser/misc_metrics/BUILD.gn
browser/misc_metrics/extension_metrics_service.cc => browser/misc_metrics/extension_metrics.cc
browser/misc_metrics/extension_metrics_service.h => browser/misc_metrics/extension_metrics.h
browser/misc_metrics/extension_metrics_service_factory.cc
browser/misc_metrics/misc_android_metrics_factory.cc, browser/misc_metrics/misc_android_metrics_factory.h
browser/misc_metrics/misc_android_metrics_factory_android.cc
browser/misc_metrics/page_metrics_service_factory.cc, browser/misc_metrics/page_metrics_service_factory.h
browser/misc_metrics/page_metrics_tab_helper.cc, browser/misc_metrics/page_metrics_tab_helper.h
browser/misc_metrics/page_metrics_service_unittest.cc => browser/misc_metrics/page_metrics_unittest.cc
a/browser/misc_metrics/profile_misc_metrics_service.cc, a/browser/misc_metrics/profile_misc_metrics_service.h
browser/misc_metrics/sources.gni
browser/profiles/brave_profile_manager.cc
components/misc_metrics/BUILD.gn
a/components/misc_metrics/language_metrics.cc, a/components/misc_metrics/language_metrics.h, a/components/misc_metrics/language_metrics_unittest.cc
components/misc_metrics/page_metrics_service.cc => components/misc_metrics/page_metrics.cc, components/misc_metrics/page_metrics_service.h => components/misc_metrics/page_metrics.h
components/p3a/metric_names.h
Security Hotspots
|
1062166
to
9cb68f9
Compare
Resolves brave/brave-browser#34853
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Ensure metric only appears in the
logs_constellation_prep_express
object in local state (and maybeconstellation_logs_slow
if the metric was encrypted/prepared at the time of viewing the local state page).Ensure the metric value matches the primary language set in the browser. The answer should match the relevant index in this list of languages:
brave-core/components/misc_metrics/language_metrics.cc
Lines 26 to 210 in a317944